Skip to content

vmalert: rewrite tests using f-test #1570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 24, 2025
Merged

vmalert: rewrite tests using f-test #1570

merged 1 commit into from
Oct 24, 2025

Conversation

@AndrewChubatiuk
Copy link
Contributor

@AndrewChubatiuk AndrewChubatiuk commented Oct 23, 2025 •
edited
Loading

also add test case for initial concern from issue, that is linked to #703

@AndrewChubatiuk AndrewChubatiuk force-pushed the vmalert-do-not-modify-original-notifiers branch 2 times, most recently from f23cfb8 to 801f1e1 Compare October 23, 2025 13:23
f41gh7
f41gh7 requested changes Oct 23, 2025
View reviewed changes
Copy link
Collaborator

@f41gh7 f41gh7 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide better description to the commit message.

For me it's unclear, how this change is related to the linked PR. It'd be also great to have an entry at changelog.

Also, please avoid using dynamic requests with rclient at builder functions.

@AndrewChubatiuk AndrewChubatiuk force-pushed the vmalert-do-not-modify-original-notifiers branch from 801f1e1 to cc0d3e4 Compare October 24, 2025 11:28
@AndrewChubatiuk AndrewChubatiuk changed the title vmalert: do not modify notifiers in CR vmalert: do not overwrite notifiers during discover Oct 24, 2025
@AndrewChubatiuk AndrewChubatiuk force-pushed the vmalert-do-not-modify-original-notifiers branch from cc0d3e4 to 755c217 Compare October 24, 2025 13:16
@AndrewChubatiuk AndrewChubatiuk changed the title vmalert: do not overwrite notifiers during discover vmalert: f-test Oct 24, 2025
@AndrewChubatiuk AndrewChubatiuk changed the title vmalert: f-test vmalert: rewrite tests using f-test Oct 24, 2025
@AndrewChubatiuk AndrewChubatiuk force-pushed the vmalert-do-not-modify-original-notifiers branch from 755c217 to 05ef46b Compare October 24, 2025 13:26
f41gh7
f41gh7 approved these changes Oct 24, 2025
View reviewed changes
Copy link
Collaborator

@f41gh7 f41gh7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@f41gh7 f41gh7 merged commit 8f290b8 into master Oct 24, 2025
6 checks passed
@f41gh7 f41gh7 deleted the vmalert-do-not-modify-original-notifiers branch October 24, 2025 18:27
@f41gh7
Copy link
Collaborator

f41gh7 commented Oct 24, 2025

Thanks for contribution!

@AndrewChubatiuk AndrewChubatiuk mentioned this pull request Oct 24, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@f41gh7 f41gh7 f41gh7 approved these changes

@Haleygo Haleygo Awaiting requested review from Haleygo Haleygo is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AndrewChubatiuk @f41gh7