Improve type detection of literals in ternary expressions#527
Open
PiTheGuy wants to merge 2 commits intoVineflower:develop/1.12.0from
Open
Improve type detection of literals in ternary expressions#527PiTheGuy wants to merge 2 commits intoVineflower:develop/1.12.0from
PiTheGuy wants to merge 2 commits intoVineflower:develop/1.12.0from
Conversation
jaskarth
added
Type: Enhancement
Member
|
Hey, thanks a lot for the PR! Could you check if this test produces the proper result on develop/1.12.0 without the change to FunctionExprent? There was an earlier change that aimed to fix this: 5237b68 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where int literals between 32768 - 65535 were displayed as char literals even if they were in a ternary expression whose other side was an int.