Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow commiting of files large than 100mb if handled by LFS #822

Conversation

TimonGisler
Copy link
Contributor

@TimonGisler TimonGisler commented Dec 3, 2024

The plugin refuses to add files bigger than 100mb if the remote is github, even if an file is handled by LFS.

I added some logic that checks if a file is (or will be) handled by LFS, before blocking the commit.

Detailed Problem Description
Commit Where Check for Too Big Files Was Added

I have not yet implemented IsomorphicGit, but I am happy to do that if I get feedback on whether my change is being considered.
The changes were only tested on my Windows 11 machine (not on Linux or macOS).

This is my first ever PR to an open source project, so any feedback is welcome. I would be very happy if this actually were merged. :D

@TimonGisler TimonGisler changed the title Check if file is tracked by lfs before blocking commit [bug fix] Allow commiting of files large than 100mb if handled by LFS Dec 3, 2024
Copy link
Owner

@Vinzent03 Vinzent03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this pr! Just some comments about a bit of different structure, and you will need to fix the formatting with prettier.

@Vinzent03
Copy link
Owner

Thanks for the fixes. I just noticed that you are currently passing the vault_path to the git lfs check, but it needs the repo relative path, which is currently not stored in those objects. So it needs a bit more of restructure, which I will add to this pr in the next days.

@Vinzent03 Vinzent03 changed the title [bug fix] Allow commiting of files large than 100mb if handled by LFS fix: Allow commiting of files large than 100mb if handled by LFS Jan 1, 2025
@Vinzent03 Vinzent03 merged commit e67928d into Vinzent03:master Jan 1, 2025
5 checks passed
Vinzent03 added a commit that referenced this pull request Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants