Skip to content

feat(VCST-3928): save for later optimistic response #1956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: dev
Choose a base branch
from
Draft

feat(VCST-3928): save for later optimistic response #1956

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4554133
feat: optimistic responses
yuskithedeveloper Sep 19, 2025
a911126
Merge branch 'dev' into feat/VCST-3928-save-for-later-optimistic-resp…
yuskithedeveloper Sep 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 47 additions & 18 deletions client-app/shared/cart/composables/useSaveForLater.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,14 @@ import { MoveToSavedForLaterDocument, MoveFromSavedForLaterDocument } from "@/co
import { useMutationBatcher } from "@/core/composables/useMutationBatcher";
import { globals } from "@/core/globals";
import { Logger } from "@/core/utilities";
import { useFullCart } from "@/shared/cart";
import type { SavedForLaterListFragment } from "@/core/api/graphql/types";

function _useSavedForLater() {
const { storeId, currencyCode, cultureName, userId } = globals;

const { cart } = useFullCart();

const savedForLaterList = ref<SavedForLaterListFragment>();

const { mutate: _moveToSavedForLater, loading: _moveToSavedForLaterLoading } =
Expand All @@ -26,16 +29,29 @@ function _useSavedForLater() {

async function moveToSavedForLater(cartId: string, itemIds: string[]) {
try {
const moveResult = await _moveToSavedForLaterBatched({
command: {
storeId,
userId,
cultureName,
currencyCode,
cartId,
lineItemIds: itemIds,
const moveResult = await _moveToSavedForLaterBatched(
{
command: {
storeId,
userId,
cultureName,
currencyCode,
cartId,
lineItemIds: itemIds,
},
},
{
optimisticResponse: {
moveToSavedForLater: {
cart: {
...cart.value!,
items: cart.value!.items.filter((item) => !itemIds.includes(item.id)),
},
list: savedForLaterList.value,
},
},
},
});
);

savedForLaterList.value = moveResult?.data?.moveToSavedForLater?.list;
} catch (err) {
Expand All @@ -57,16 +73,29 @@ function _useSavedForLater() {

async function moveFromSavedForLater(cartId: string, itemIds: string[]) {
try {
const moveResult = await _moveFromSavedForLaterBatched({
command: {
storeId,
userId,
cultureName,
currencyCode,
cartId,
lineItemIds: itemIds,
const moveResult = await _moveFromSavedForLaterBatched(
{
command: {
storeId,
userId,
cultureName,
currencyCode,
cartId,
lineItemIds: itemIds,
},
},
{
optimisticResponse: {
moveFromSavedForLater: {
cart: cart.value,
list: {
...savedForLaterList.value!,
items: savedForLaterList.value!.items.filter((item) => !itemIds.includes(item.id)),
},
},
},
},
});
);

savedForLaterList.value = moveResult?.data?.moveFromSavedForLater?.list;
} catch (err) {
Expand Down