VCST-5450: Supported dictionary settings and tenant scope in settings v2 API - #3098
Merged
Conversation
|
|
OlegoO
approved these changes
Aug 10, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Infrastructure change enabling store-scoped dictionary (multi-value) settings in the Settings V2 API — a prerequisite for the customer module's per-store role whitelist, which needs to store/read a list of role names scoped to a specific store rather than a single scalar value.
What was added
SettingsPropertyService:GetValuesAsync/SaveValuesAsyncnow branch onIsDictionary, reading/writing the setting'sAllowedValuesarray per tenant scope instead of assuming a single scalarValue; refactored into smaller resolve/build helper methods to keep Cognitive/Cyclomatic complexity within the repo's Sonar thresholds.setting-dictionary.js: the dictionary-setting blade now supports store/tenant-scoped values (viasettingsV2) in addition to existing global-only editing.settings-unified.js: routes dictionary-type settings through the same tenant-aware save path.Breaking changes
None — only internal/private helper methods were added or restructured; no public method signatures changed.
Tests
SettingsPropertyServiceTestsextended to cover dictionary + tenant-scope read/write and default-value resolutionReferences
QA-test:
Jira-link:
https://virtocommerce.atlassian.net/browse/VCST-5450
Artifact URL:
Image tag:
ghcr.io/VirtoCommerce/platform:3.1063.0-pr-3098-057b-vcst-5450-057baf32