VCST-5623: Fixed null credential fields bug - #3100
Merged
Merged
Conversation
|
OlegoO
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
POST /api/platform/security/login returned an unhandled 500 Internal Server Error (instead of 400 Bad Request) whenever userName and/or password were null or missing from the request body. Since the endpoint is [AllowAnonymous], any unauthenticated caller could trigger this at will, polluting 5xx dashboards/alerting. Root cause: UserManager.FindByNameAsync and SignInManager.PasswordSignInAsync throw ArgumentNullException on null input, and ApiErrorWrappingMiddleware maps any unhandled exception to a blanket 500.
What's added
Added an explicit null check at the top of SecurityController.Login for request, request.UserName, and request.Password, returning 400 Bad Request before any downstream call can throw (SecurityController.cs).
Added unit tests covering null request body, null UserName, and null Password, verifying 400 Bad Request is returned; existing tests confirm empty-string userName and non-existent users still return 200 OK with succeeded: false (SecurityControllerTests.cs).
Breaking changes
None.
References
QA-test:
Jira-link:
https://virtocommerce.atlassian.net/browse/VCST-5623
Artifact URL:
Image tag:
ghcr.io/VirtoCommerce/platform:3.1059.0-pr-3100-1f33-vcst-5623-1f33fba0