Feat/vchart editor:Add VChartSpec Atom and demo of vchart editor #197
Conversation
feat: merge spec of vchart
Feat/vchart editor merge spec
chore: update jest to 0.29
Fix/merge spec 2
…into feat/vchart_editor
test: update test case of bar
…into feat/vchart_editor
fix: fix error of `set`
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -52,10 +52,15 @@ | |||
| sparse_vector: (sparseVector ?? []) | |||
| .map(item => { | |||
| // 使用正则表达式解析字符串 | |||
| const match = item.match(/\('(.+)', ([\d.]+)\)/); | |||
| const match = item.match(/\("(.+?)", ([\d.]+)\)/); | |||
Check failure
Code scanning / CodeQL
Polynomial regular expression used on uncontrolled data High
| if (match) { | ||
| return [match[1], parseFloat(match[2])]; | ||
| } | ||
| const oldMatch = item.match(/\('(.+)', ([\d.]+)\)/); |
Check failure
Code scanning / CodeQL
Polynomial regular expression used on uncontrolled data High
| if (isValid(nested[key])) { | ||
| merge(nested, { [key]: newValue }); | ||
| } else { | ||
| nested[key] = newValue; |
Check warning
Code scanning / CodeQL
Prototype-polluting function Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 3 months ago
To fix the problem, we need to ensure that the key variable does not include any properties that can lead to prototype pollution, such as __proto__ or constructor. We can achieve this by adding a check to skip these properties before performing the assignment.
- Add a check to skip
__proto__andconstructorproperties in thebaseSetfunction. - This change should be made in the
baseSetfunction in the filepackages/vmind/src/utils/set.ts.
| @@ -65,2 +65,5 @@ | ||
| const key = path[index]; | ||
| if (key === "__proto__" || key === "constructor") { | ||
| continue; | ||
| } | ||
| let newValue = value; |
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
🔗 Related PR link
🐞 Bugserver case id
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
copilot:summary
🔍 Walkthrough
copilot:walkthrough