fix: preserve custom layout falsy values#5196
Merged
fangsmile merged 1 commit intoJun 25, 2026
Merged
Conversation
biubiukam
marked this pull request as ready for review
June 24, 2026 08:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a ...
Related issue link
close #1949
Background and solution
Custom layout and custom render callbacks used
table.getCellValue(...) || ''for the callbackvalue. That converted valid falsy cell values such as0andfalseinto an empty string, so custom layout logic could not distinguish those values from an empty cell.This change passes
table.getCellValue(...)through directly for custom layout and custom render callback args, the custom width/height measurement paths, and React custom layout updates.Changelog
Self-Check before Merge
Please check all items below before requesting a reviewing.
Summary
0andfalsecell values in custom layout and custom render callback args.Walkthrough
0andfalsecallback values.Validation
node ../../common/scripts/install-run-rushx.js test -- columns/listTable-custom-layout.test.ts --runInBandnode common/scripts/install-run-rush.js build -t @visactor/react-vtablenode common/scripts/install-run-rush.js build -t @visactor/vtable-sheetgit push -u origin fix/issue-1949-custom-layout-value