webkitSupportsPresentationMode("picture-in-picture") is not reliable …

…on mobile safari
Vladislavik · May 4, 2017 · 4d39d22 · 4d39d22
1 parent 6b4788b
commit 4d39d22
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/dist/videojs.pip.js b/dist/videojs.pip.js
@@ -72,7 +72,7 @@ var PipButton = function PipButton(options) {
 
   if (video.webkitSupportsPresentationMode && typeof video.webkitSetPresentationMode === "function") {
     player.on('loadeddata', function () {
-      if (!player.controlBar.childNameIndex_.hasOwnProperty('PipToggle') && video.webkitSupportsPresentationMode("picture-in-picture")) {
+      if (!player.controlBar.childNameIndex_.hasOwnProperty('PipToggle') && !window.navigator.userAgent.match(/iPhone/)) {
         var PipToggle = this.controlBar.addChild('PipToggle', options);
         player.controlBar.el().insertBefore(PipToggle.el(), player.controlBar.fullscreenToggle.el());
       }

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "videojs-pip",
-  "version": "1.0.2",
+  "version": "1.0.3",
   "description": "video.js plugin to add a PIP button if the browser supports webkitSupportsPresentationMode",
   "repository": {
     "type": "git",

diff --git a/videojs-pip.js b/videojs-pip.js
@@ -41,7 +41,7 @@ const PipButton = function(options) {
 
   if (video.webkitSupportsPresentationMode && typeof video.webkitSetPresentationMode === "function") {
     player.on('loadeddata', function() {
-      if (!player.controlBar.childNameIndex_.hasOwnProperty('PipToggle') && video.webkitSupportsPresentationMode("picture-in-picture")) {
+      if (!player.controlBar.childNameIndex_.hasOwnProperty('PipToggle') && !window.navigator.userAgent.match(/iPhone/)) {
         var PipToggle = this.controlBar.addChild('PipToggle', options)
         player.controlBar.el().insertBefore(PipToggle.el(), player.controlBar.fullscreenToggle.el())
       }