Repository navigation
fix(harness): classify beyond-engine primitives before capability_absent - #1
Merged
Merged
Conversation
rfl now reports an unimplemented primitive as capability_absent for that primitive, so beyond-engine skills (place.put_down, place.stack) retargeted onto a descriptor that cannot declare them were misclassified as capability_rejected. Give the engine-coverage gate precedence: a skill using any primitive outside ENGINE_18 is beyond_engine (a coverage gap), and only skills built purely from ENGINE_18 can be a genuine capability_rejected. Co-authored-by: Codesmith <codesmith-bot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The
testjob onmainfails 5 tests, all in the 4-way retarget gate:pourandstack-blocks(and theBEYONDfixture) are expected to classify asbeyond_enginebut come back ascapability_rejected.CI builds the rfl binding from the head of the public
robotfoundationlayer/rflrepo (unpinned in.github/workflows/ci.yml). Upstream rfl now reports an unimplemented primitive ascapability_absent: <primitive>when it is retargeted onto a descriptor that cannot declare it. Inretarget_outcome, thecapability_absentmessage check ran before the engine-coverage check, so a beyond-engine skill (place.put_down,place.stack) whose primitive is absent from the descriptor got taggedcapability_rejected.Per the documented gate order (CLAUDE.md gate #2), a valid emission the engine cannot lower is
beyond_engine(a coverage gap, NOT a model error), and rfl / vendored descriptors are consumed-only. So the fix is entirely in cobel's classification logic.What
Give the engine-coverage gate precedence over the embodiment-mismatch path:
A skill built purely from
ENGINE_18still has an emptyprimitives_used - ENGINE_18, so genuine embodiment mismatches (seat-fuse,latch-buckleon a no-F/T arm) remaincapability_rejected.sort-by-weightstaysbeyond_engine, and themalformed/retarget_okpaths are unaffected.Verified by reproducing CI locally (rfl binding built from the public repo): full suite now
35 passed(was 5 failed, 30 passed).Need help on this PR? Tag
/codesmithwith what you need. Autofix is enabled.