-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alternate B&A header mechanism to facilitate delaying response to body #1233
Open
JensenPaul
wants to merge
3
commits into
main
Choose a base branch
from
JensenPaul-patch-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacobGo
reviewed
Jan 2, 2025
@@ -84,6 +84,16 @@ and both versions should be accepted. | |||
|
|||
It should be noted that the `fetch()` request using `adAuctionHeaders` can also be used to send `auctionBlob` (e.g. in the request body) and receive the response blob (e.g. in the response body). | |||
|
|||
#### Alternate header to facilitate delaying response blobs to response body | |||
|
|||
The aforementioned Step 3 includes the hash of the response blob in an `Ad-Auction-Result` HTTP response header, which requires that the response blob be available before the HTTP response headers are sent back to the device. If the server operator wants to instead delay inclusion of the response blob until the HTTP response body is sent back to the device, they can instead omit the `Ad-Auction-Result` HTTP header and instead: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be useful to explicitly clarify why the server operator might delay inclusion of the response blob, either inlined here or by linking to additional documentation for context. As written, the latency implications and data dependency in common ad server flows is unclear.
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jan 7, 2025
Add support for the alternate authorization flow for Protected Audiences Bidding and Auction response (as described in WICG/turtledove#1233). This feature is behind the FledgeBiddingAndAuctionNonceSupport feature flag which is going to be enabled by default (for a waterfall rollout in M133). Bug:385128725 Change-Id: Id3c622241c82ed0b71037bfeb1ca5432cd6e66dc
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jan 7, 2025
Add support for the alternate authorization flow for Protected Audiences Bidding and Auction response (as described in WICG/turtledove#1233). This feature is behind the FledgeBiddingAndAuctionNonceSupport feature flag which is going to be enabled by default (for a waterfall rollout in M133). Bug:385128725 Change-Id: Id3c622241c82ed0b71037bfeb1ca5432cd6e66dc
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Jan 7, 2025
Add support for the alternate authorization flow for Protected Audiences Bidding and Auction response (as described in WICG/turtledove#1233). This feature is behind the FledgeBiddingAndAuctionNonceSupport feature flag which is going to be enabled by default (for a waterfall rollout in M133). Bug: 385128725 Change-Id: Id3c622241c82ed0b71037bfeb1ca5432cd6e66dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6109795 Reviewed-by: Maks Orlovich <[email protected]> Commit-Queue: Russ Hamilton <[email protected]> Reviewed-by: Brendon Tiszka <[email protected]> Cr-Commit-Position: refs/heads/main@{#1403077}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jan 7, 2025
Add support for the alternate authorization flow for Protected Audiences Bidding and Auction response (as described in WICG/turtledove#1233). This feature is behind the FledgeBiddingAndAuctionNonceSupport feature flag which is going to be enabled by default (for a waterfall rollout in M133). Bug: 385128725 Change-Id: Id3c622241c82ed0b71037bfeb1ca5432cd6e66dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6109795 Reviewed-by: Maks Orlovich <[email protected]> Commit-Queue: Russ Hamilton <[email protected]> Reviewed-by: Brendon Tiszka <[email protected]> Cr-Commit-Position: refs/heads/main@{#1403077}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jan 7, 2025
Add support for the alternate authorization flow for Protected Audiences Bidding and Auction response (as described in WICG/turtledove#1233). This feature is behind the FledgeBiddingAndAuctionNonceSupport feature flag which is going to be enabled by default (for a waterfall rollout in M133). Bug: 385128725 Change-Id: Id3c622241c82ed0b71037bfeb1ca5432cd6e66dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6109795 Reviewed-by: Maks Orlovich <[email protected]> Commit-Queue: Russ Hamilton <[email protected]> Reviewed-by: Brendon Tiszka <[email protected]> Cr-Commit-Position: refs/heads/main@{#1403077}
i3roly
pushed a commit
to i3roly/firefox-dynasty
that referenced
this pull request
Jan 10, 2025
…header for PA B&A, a=testonly Automatic update from web-platform-tests Add support for Ad-Auction-Result-Nonce header for PA B&A Add support for the alternate authorization flow for Protected Audiences Bidding and Auction response (as described in WICG/turtledove#1233). This feature is behind the FledgeBiddingAndAuctionNonceSupport feature flag which is going to be enabled by default (for a waterfall rollout in M133). Bug: 385128725 Change-Id: Id3c622241c82ed0b71037bfeb1ca5432cd6e66dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6109795 Reviewed-by: Maks Orlovich <[email protected]> Commit-Queue: Russ Hamilton <[email protected]> Reviewed-by: Brendon Tiszka <[email protected]> Cr-Commit-Position: refs/heads/main@{#1403077} -- wpt-commits: 48f9ec1e463fbe03e411a77dae446b7c6de4f577 wpt-pr: 49954
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jan 10, 2025
…header for PA B&A, a=testonly Automatic update from web-platform-tests Add support for Ad-Auction-Result-Nonce header for PA B&A Add support for the alternate authorization flow for Protected Audiences Bidding and Auction response (as described in WICG/turtledove#1233). This feature is behind the FledgeBiddingAndAuctionNonceSupport feature flag which is going to be enabled by default (for a waterfall rollout in M133). Bug: 385128725 Change-Id: Id3c622241c82ed0b71037bfeb1ca5432cd6e66dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6109795 Reviewed-by: Maks Orlovich <[email protected]> Commit-Queue: Russ Hamilton <[email protected]> Reviewed-by: Brendon Tiszka <[email protected]> Cr-Commit-Position: refs/heads/main@{#1403077} -- wpt-commits: 48f9ec1e463fbe03e411a77dae446b7c6de4f577 wpt-pr: 49954
sadym-chromium
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jan 14, 2025
Add support for the alternate authorization flow for Protected Audiences Bidding and Auction response (as described in WICG/turtledove#1233). This feature is behind the FledgeBiddingAndAuctionNonceSupport feature flag which is going to be enabled by default (for a waterfall rollout in M133). Bug: 385128725 Change-Id: Id3c622241c82ed0b71037bfeb1ca5432cd6e66dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6109795 Reviewed-by: Maks Orlovich <[email protected]> Commit-Queue: Russ Hamilton <[email protected]> Reviewed-by: Brendon Tiszka <[email protected]> Cr-Commit-Position: refs/heads/main@{#1403077}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.