Include section on cleartext req/resp headers #1377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To match IETF spec
JensenPaul
reviewed
Jan 13, 2025
FLEDGE_Key_Value_Server_API.md
Outdated
|
|
||
| Requests contain a cleartext HTTP `Content-Type` header with value `message/ad-auction-trusted-signals-request`. | ||
|
|
||
| Responses contain a cleartext HTTP `Content-Type` header with value `message/ad-auction-trusted-signals-response`. |
There was a problem hiding this comment.
I don't think we can necessarily specify what a response does contain, I think we can specify what it must contain. Further, this begs the question of who adds this response header? the TKV code or the HTTPS-terminating front-end in front of the TKV? I think the HTTPS-terminating front-end.
There was a problem hiding this comment.
The server does actually set the content-type in the TKV code as part of the http response. The transcoding itself happens in envoy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To match KV IETF spec