In PA KVv2 API, replace renderUrl/componentRenderUrl with renderURL / componentRenderURL #1383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… componentRenderURL. This better matches the other APIs. The server implementation already supports both, and we'll soon be switching Chrome as well.
Update spec, sort of
|
Oops, didn't realize #1381 existed. I think we need the spec changes as well (The spec does look a bit broken here - it appears to write render and component URLs to the same destination map, which is not something we ever do) |
|
I merged #1381 and updated this PR, so it's just modifying the spec. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This better matches the other APIs. The server implementation already supports both, and we'll soon be switching Chrome as well.
Preview | Diff