Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse Ad-Auction-Additional-Bid response header #888

Merged
merged 9 commits into from
Nov 14, 2023

Conversation

qingxinwu
Copy link
Collaborator

@qingxinwu qingxinwu commented Oct 27, 2023

Parse Ad-Auction-Additional-Bid response header to get additional bids.
Since it has the same way with direct from seller signals, so makes the existing algorithms more general for the two use cases, and changed the section header for "Direct from seller signals" to something more general "Fetch Patch for Auction Headers"

Plan to move the "Fetch Patch for Auction Headers" section right after "Additional Bids" section, but to make this PR easier to review, going to do that in a future PR.


Preview | Diff

@qingxinwu qingxinwu added the spec Relates to the spec label Oct 27, 2023
@qingxinwu qingxinwu requested a review from caraitto October 27, 2023 15:23
@qingxinwu
Copy link
Collaborator Author

qingxinwu commented Oct 27, 2023

@caraitto PTAL. Feel free to suggest other ways to orgnize the algorithms. Plan to move the "Fetch Patch for Auction Headers" section right after "Additional Bids" section, but will do it in a future PR.

{{WindowOrWorkerGlobalScope/fetch()}} call (using the {{RequestInit/adAuctionHeaders}} option)
initiated by any *other* {{Document}} in the *same* [=traversable navigable=].
derived from JSON from an [:Ad-Auction-Signals:] header, or [=additional bids=] derived from an
[:Ad-Auction-Additional-Bid:] header, captured by a {{WindowOrWorkerGlobalScope/fetch()}} call
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

captured by a {{WindowOrWorkerGlobalScope/fetch()}} call (using the {{RequestInit/adAuctionHeaders}} option)

There is also pending support for an iframe attribute mechanism.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we'll need to handle the merge of this PR with #883, depending on which one lands first.

spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
{{WindowOrWorkerGlobalScope/fetch()}} call (using the {{RequestInit/adAuctionHeaders}} option)
initiated by any *other* {{Document}} in the *same* [=traversable navigable=].
derived from JSON from an [:Ad-Auction-Signals:] header, or [=additional bids=] derived from an
[:Ad-Auction-Additional-Bid:] header, captured by a {{WindowOrWorkerGlobalScope/fetch()}} call
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we'll need to handle the merge of this PR with #883, depending on which one lands first.

spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Show resolved Hide resolved
spec.bs Show resolved Hide resolved
@qingxinwu qingxinwu requested a review from caraitto November 3, 2023 05:23
Copy link
Collaborator

@caraitto caraitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good % comments

spec.bs Outdated Show resolved Hide resolved
spec.bs Show resolved Hide resolved
@qingxinwu
Copy link
Collaborator Author

qingxinwu commented Nov 9, 2023

@domfarolino Mind taking a look? The real meaningful change is in algorithm [=update captured headers=]. Other changes are just moving existing contents around to reorgnize them.

Copy link
Collaborator

@caraitto caraitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please wait for Dominic's review.

@JensenPaul JensenPaul merged commit 3de7fde into WICG:main Nov 14, 2023
github-actions bot added a commit that referenced this pull request Nov 14, 2023
SHA: 3de7fde
Reason: push, by JensenPaul

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit to MattMenke2/turtledove that referenced this pull request Nov 14, 2023
SHA: 3de7fde
Reason: push, by MattMenke2

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@qingxinwu qingxinwu deleted the negheader branch November 14, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec Relates to the spec
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants