Clarify that declarative custom element definitions don't contain declarative shadow roots. #1101
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current Declarative Custom Elements Strawman was authored before Declarative Custom Elements was specified, and the pattern of putting shadow root instance options on the
<template>
element. Now that that pattern does exist, it has created something of an semantic ambiguity with the strawman syntax. (with the assumption thatshadowmode
should be updated toshadowrootmode
).In this example, is
<template shadowmode="open">
intended to do?Does it:
<definition>
elementIf the answer is (2), then we have the same syntax with two different behaviors: one creates a shadow root instance, one defines future shadow roots.
Since the strawman was created before DSD, it doesn't seem like this collision was intended. I think to separate DSD from declarative custom elements, even just in this strawman syntax, we should make a small edit to put the options on a new element. This has the benefit of shortening the option names by not requiring the
shadowroot
prefix on every one.cc @rniwa