Skip to content

fix(Admin): Access Count today always shows 0#301

Merged
hirokiterashima merged 1 commit intodevelopfrom
issue-293-access-count-0
Apr 25, 2025
Merged

fix(Admin): Access Count today always shows 0#301
hirokiterashima merged 1 commit intodevelopfrom
issue-293-access-count-0

Conversation

@Aaron-Detre
Copy link
Copy Markdown
Contributor

Changes

  • Check that student login times are after the start of the day rather than after the current time.

Test

  • Make sure that the access count today is accurate and no longer stuck at 0.

Closes #293

@Aaron-Detre Aaron-Detre self-assigned this Apr 21, 2025
@Aaron-Detre Aaron-Detre added the bug Something isn't working label Apr 21, 2025
@Aaron-Detre Aaron-Detre marked this pull request as ready for review April 21, 2025 19:24
@hirokiterashima hirokiterashima changed the title Compare student login times to start of day fix(Admin): Access Count today always shows 0 Apr 25, 2025
Copy link
Copy Markdown
Member

@hirokiterashima hirokiterashima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hirokiterashima hirokiterashima merged commit b462368 into develop Apr 25, 2025
3 checks passed
@hirokiterashima hirokiterashima deleted the issue-293-access-count-0 branch April 25, 2025 22:59
@hirokiterashima
Copy link
Copy Markdown
Member

🎉 This PR is included in version 1.10.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(Admin): Access Count today always shows 0

2 participants