Skip to content

refactor(MatchService): Simplify test setup and remove unused getItemById()#2052

Merged
hirokiterashima merged 1 commit intodevelopfrom
refactor-matchService-remove-getItemById
Jan 16, 2025
Merged

refactor(MatchService): Simplify test setup and remove unused getItemById()#2052
hirokiterashima merged 1 commit intodevelopfrom
refactor-matchService-remove-getItemById

Conversation

@hirokiterashima
Copy link
Member

Changes

  • Remove getItemById(). It wasn't being called from anywhere.
  • Remove empty constructor
  • Clean up tests

Test

  • Everything works as before

@hirokiterashima hirokiterashima self-assigned this Jan 16, 2025
@hirokiterashima hirokiterashima marked this pull request as ready for review January 16, 2025 23:04
@hirokiterashima hirokiterashima merged commit 220bce7 into develop Jan 16, 2025
@hirokiterashima hirokiterashima deleted the refactor-matchService-remove-getItemById branch January 16, 2025 23:14
@hirokiterashima
Copy link
Member Author

🎉 This issue has been resolved in version 5.166.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant