refactor(MatchChoiceItem): Convert to standalone#2063
Closed
Aaron-Detre wants to merge 9 commits intodevelopfrom
Closed
refactor(MatchChoiceItem): Convert to standalone#2063Aaron-Detre wants to merge 9 commits intodevelopfrom
Aaron-Detre wants to merge 9 commits intodevelopfrom
Conversation
Member
|
The delete button doesn't show up for choices that were created by the student. You'll need to convert DeleteChoiceButton into a standalone component first, then import it in this component. |
…ceButtonComponent
hirokiterashima
requested changes
Jan 26, 2025
Member
There was a problem hiding this comment.
There are some conflicts to resolve.
Make sure that your develop is up-to-date and merge the latest from develop to this branch
git checkout develop
git pull
git checkout issue-2051-MatchChoiceItem-Standalone
git merge develop
Resolve conflicts, make sure that everything works.
Push your changes and re-request review.
…iceItem-Standalone' into issue-2051-MatchChoiceItem-Standalone
…iceItem-Standalone' into issue-2051-MatchChoiceItem-Standalone
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Test
Closes #2051