Skip to content

refactor(MatchChoiceItem): Convert to standalone#2063

Closed
Aaron-Detre wants to merge 9 commits intodevelopfrom
issue-2051-MatchChoiceItem-Standalone
Closed

refactor(MatchChoiceItem): Convert to standalone#2063
Aaron-Detre wants to merge 9 commits intodevelopfrom
issue-2051-MatchChoiceItem-Standalone

Conversation

@Aaron-Detre
Copy link
Copy Markdown
Contributor

@Aaron-Detre Aaron-Detre commented Jan 23, 2025

Changes

  • Converted MatchChoiceItem to standalone.

Test

  • Items appear with the correct text.
  • When answers are submitted, items are marked with the appropriate feedback text.
  • When answers are submitted, correct answers are marked with a checkmark and a green background, and incorrect answers are marked with an X and a red background.

Closes #2051

@Aaron-Detre Aaron-Detre marked this pull request as ready for review January 23, 2025 16:24
@hirokiterashima
Copy link
Copy Markdown
Member

The delete button doesn't show up for choices that were created by the student. You'll need to convert DeleteChoiceButton into a standalone component first, then import it in this component.

Copy link
Copy Markdown
Member

@hirokiterashima hirokiterashima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some conflicts to resolve.

Make sure that your develop is up-to-date and merge the latest from develop to this branch

git checkout develop
git pull
git checkout issue-2051-MatchChoiceItem-Standalone
git merge develop

Resolve conflicts, make sure that everything works.
Push your changes and re-request review.

@Aaron-Detre Aaron-Detre requested review from hirokiterashima and removed request for hirokiterashima January 28, 2025 19:41
@Aaron-Detre Aaron-Detre deleted the issue-2051-MatchChoiceItem-Standalone branch March 19, 2025 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor(MatchChoiceItem): Convert to standalone

2 participants