-
Notifications
You must be signed in to change notification settings - Fork 5
feat(Grade By Step): Summarize student work using AI #2266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hirokiterashima
wants to merge
17
commits into
develop
Choose a base branch
from
cm-component-ai-summarizer
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
1e1682f
feat(OpenResponse): Summarize student responses in grading tool (#2259)
hirokiterashima d99fdcc
feat(Discussion): Summarize student responses in grading tool (#2262)
hirokiterashima e098623
refactor: OpenResponseSummaryDisplay now extends AiSummaryDisplay
hirokiterashima 2c0276b
refactor: make code more concise
hirokiterashima dc62b55
Merge branch 'develop' into cm-component-ai-summarizer
hirokiterashima 2eeb2d2
Merge branch 'develop' into cm-component-ai-summarizer
hirokiterashima 60dd9ec
Merge branch 'develop' into cm-component-ai-summarizer
hirokiterashima e240501
Rename class to DiscussionAISummaryComponent
hirokiterashima efe24eb
Rename class to OpenResponseAiSummaryComponent
hirokiterashima e44a4ac
Merge branch 'develop' into cm-component-ai-summarizer
hirokiterashima ebd1f27
AiSummaryDisplayComponent is now its own base class, no longer extend…
hirokiterashima 2831717
Rename AiSummaryDisplayComponent -> AiSummaryComponent
hirokiterashima c25dc72
Rename to AwsBedRockChatService. Rename class variable to chatService…
hirokiterashima c2f085a
Move generateChatTitle() to ChatbotComponent
hirokiterashima e4827e8
Make ChatService abstract, and create OpenAiChatService that extends …
hirokiterashima 3d22f9a
Change AiSummary to use OpenAI model as default
hirokiterashima 2c3501f
fix unit tests
hirokiterashima File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| import { Injectable } from '@angular/core'; | ||
|
|
||
| @Injectable({ | ||
| providedIn: 'root' | ||
| }) | ||
| export class LocalStorageService { | ||
| setItem(key: string, value: any): void { | ||
| try { | ||
| localStorage.setItem(key, JSON.stringify(value)); | ||
| } catch (e) { | ||
| console.error('Error saving to local storage', e); | ||
| } | ||
| } | ||
|
|
||
| getItem(key: string): any { | ||
| try { | ||
| const item = localStorage.getItem(key); | ||
| return item ? JSON.parse(item) : null; | ||
| } catch (e) { | ||
| console.error('Error reading from local storage', e); | ||
| return null; | ||
| } | ||
| } | ||
|
|
||
| removeItem(key: string): void { | ||
| try { | ||
| localStorage.removeItem(key); | ||
| } catch (e) { | ||
| console.error('Error removing from local storage', e); | ||
| } | ||
| } | ||
|
|
||
| clear(): void { | ||
| try { | ||
| localStorage.clear(); | ||
| } catch (e) { | ||
| console.error('Error clearing local storage', e); | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,14 +14,19 @@ import { IdeasSummaryComponent } from '../../../directives/teacher-summary-displ | |
| import { MatchSummaryDisplayComponent } from '../../../directives/teacher-summary-display/match-summary-display/match-summary-display.component'; | ||
| import { MatCardModule } from '@angular/material/card'; | ||
| import { CRaterService } from '../../../services/cRaterService'; | ||
| import { OpenResponseSummaryDisplayComponent } from '../../../directives/teacher-summary-display/open-response-summary-display/open-response-summary-display.component'; | ||
| import { ProjectService } from '../../../services/projectService'; | ||
| import { DiscussionSummaryDisplayComponent } from '../../../directives/teacher-summary-display/discussion-summary-display/discussion-summary-display.component'; | ||
|
|
||
| @Component({ | ||
| imports: [ | ||
| ComponentCompletionComponent, | ||
| DiscussionSummaryDisplayComponent, | ||
| IdeasSummaryComponent, | ||
| MatCardModule, | ||
| MatchSummaryDisplayComponent, | ||
| MilestoneReportButtonComponent, | ||
| OpenResponseSummaryDisplayComponent, | ||
| PeerGroupButtonComponent, | ||
| TeacherSummaryDisplayComponent | ||
| ], | ||
|
|
@@ -48,6 +53,7 @@ export class ComponentSummaryComponent { | |
| private componentServiceLookupService: ComponentServiceLookupService, | ||
| private cRaterService: CRaterService, | ||
| private dataService: TeacherDataService, | ||
| private projectService: ProjectService, | ||
| private summaryService: SummaryService | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| ) {} | ||
|
|
||
|
|
@@ -79,6 +85,9 @@ export class ComponentSummaryComponent { | |
| (this.hasScoresSummary && this.hasScoreAnnotation) || | ||
| this.hasIdeaRubricData || | ||
| this.component?.type === 'Match'; | ||
| if (this.component?.type === 'OpenResponse' || this.component?.type === 'Discussion') { | ||
| this.hasSummaryData = this.projectService.getProject().ai?.enabled; | ||
| } | ||
| } | ||
|
|
||
| private setSource(): void { | ||
|
|
||
24 changes: 24 additions & 0 deletions
24
...5/directives/teacher-summary-display/ai-summary-display/ai-summary-display.component.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| @if (hasStudentResponses) { | ||
| <div class="flex gap-2 flex-wrap items-center mat-caption"> | ||
| <div class="flex items-center gap-2"> | ||
| <button mat-button (click)="generateSummary()" [disabled]="generatingSummary" color="primary"> | ||
| <span i18n>Generate Class Summary</span><mat-icon>auto_awesome</mat-icon> | ||
| </button> | ||
| @if (generatingSummary) { | ||
| <mat-spinner diameter="20" /> | ||
| } | ||
| </div> | ||
| @if (newSummaryAvailable) { | ||
| <span class="info" i18n>*New responses since last summary</span> | ||
| } | ||
| </div> | ||
| @if (summary) { | ||
| <markdown [data]="summary" /> | ||
| <div class="mat-caption text-secondary" i18n> | ||
| Summary generated {{ summaryDate | date: 'short' }} from | ||
| {{ latestComponentStates.length }} responses | ||
| </div> | ||
| } | ||
| } @else { | ||
| <div i18n>No student responses</div> | ||
| } |
84 changes: 84 additions & 0 deletions
84
...se5/directives/teacher-summary-display/ai-summary-display/ai-summary-display.component.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,84 @@ | ||
| import { Component, inject } from '@angular/core'; | ||
| import { TeacherSummaryDisplayComponent } from '../teacher-summary-display.component'; | ||
| import { MatButton } from '@angular/material/button'; | ||
| import { MatIcon } from '@angular/material/icon'; | ||
| import { AwsBedRockService } from '../../../../../app/chatbot/awsBedRock.service'; | ||
| import { ChatMessage } from '../../../../../app/chatbot/chat'; | ||
| import { TeacherDataService } from '../../../services/teacherDataService'; | ||
| import { MatProgressSpinner } from '@angular/material/progress-spinner'; | ||
| import { LocalStorageService } from '../../../../../app/services/localStorageService'; | ||
| import { MarkdownComponent } from 'ngx-markdown'; | ||
| import { DatePipe } from '@angular/common'; | ||
|
|
||
| @Component({ | ||
| imports: [DatePipe, MarkdownComponent, MatButton, MatIcon, MatProgressSpinner], | ||
| templateUrl: './ai-summary-display.component.html' | ||
| }) | ||
| export abstract class AiSummaryDisplayComponent extends TeacherSummaryDisplayComponent { | ||
| protected awsBedRockService: AwsBedRockService = inject(AwsBedRockService); | ||
| protected generatingSummary: boolean = false; | ||
| protected hasStudentResponses: boolean = false; | ||
| protected latestComponentStates: any[] = []; | ||
| private localStorageService: LocalStorageService = inject(LocalStorageService); | ||
| protected newSummaryAvailable: boolean = false; | ||
| protected summary: string; | ||
| protected summaryDate: Date; | ||
|
|
||
| ngOnInit(): void { | ||
| this.renderDisplay(); | ||
| } | ||
|
|
||
| protected renderDisplay(): void { | ||
| super.renderDisplay(); | ||
| this.latestComponentStates = this.getLatestComponentStates(); | ||
| this.hasStudentResponses = this.latestComponentStates.length > 0; | ||
| if (!this.hasStudentResponses) { | ||
| return; | ||
| } | ||
| this.summary = this.localStorageService.getItem(this.getSummaryKey()) || ''; | ||
| const summaryTime = this.localStorageService.getItem(this.getSummaryTimeKey()) || 0; | ||
| this.summaryDate = new Date(summaryTime); | ||
| this.newSummaryAvailable = summaryTime > 0 && this.getLastResponseTime() > summaryTime; | ||
| } | ||
|
|
||
| private getLastResponseTime(): number { | ||
| return this.latestComponentStates.reduce( | ||
| (max, state) => Math.max(max, state.serverSaveTime), | ||
| 0 | ||
| ); | ||
| } | ||
|
|
||
| protected getLatestComponentStates(): any[] { | ||
| return (this.dataService as TeacherDataService) | ||
| .getComponentStatesByComponentId(this.componentId) | ||
| .filter((state) => state.periodId === this.periodId || this.periodId === -1) | ||
| .sort((a, b) => a.serverSaveTime - b.serverSaveTime); | ||
| } | ||
|
|
||
| protected async generateSummary(): Promise<void> { | ||
| this.generatingSummary = true; | ||
| const prompt = this.projectService.getComponent(this.nodeId, this.componentId).prompt; | ||
| this.summary = await this.awsBedRockService.sendMessage([ | ||
| new ChatMessage('system', this.getSystemPrompt(prompt), this.nodeId), | ||
| new ChatMessage('user', this.getStudentResponses(), this.nodeId) | ||
| ]); | ||
| this.localStorageService.setItem(this.getSummaryKey(), this.summary); | ||
| const summaryTime = new Date().getTime(); | ||
| this.localStorageService.setItem(this.getSummaryTimeKey(), summaryTime); | ||
| this.summaryDate = new Date(summaryTime); | ||
| this.generatingSummary = false; | ||
| this.newSummaryAvailable = false; | ||
| } | ||
|
|
||
| protected abstract getStudentResponses(): string; | ||
|
|
||
| protected abstract getSystemPrompt(prompt: string): string; | ||
|
|
||
| private getSummaryKey(): string { | ||
| return `component-summary-${this.periodId}-${this.nodeId}-${this.componentId}`; | ||
| } | ||
|
|
||
| private getSummaryTimeKey(): string { | ||
| return `component-summary-time-${this.periodId}-${this.nodeId}-${this.componentId}`; | ||
| } | ||
| } |
48 changes: 48 additions & 0 deletions
48
...eacher-summary-display/discussion-summary-display/discussion-summary-display.component.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| import { Component } from '@angular/core'; | ||
| import { MatButton } from '@angular/material/button'; | ||
| import { MatIcon } from '@angular/material/icon'; | ||
| import { MatProgressSpinner } from '@angular/material/progress-spinner'; | ||
| import { MarkdownComponent } from 'ngx-markdown'; | ||
| import { AiSummaryDisplayComponent } from '../ai-summary-display/ai-summary-display.component'; | ||
| import { DatePipe } from '@angular/common'; | ||
|
|
||
| interface Thread { | ||
| id: number; | ||
| post: string; | ||
| replies: string[]; | ||
| } | ||
|
|
||
| @Component({ | ||
| imports: [DatePipe, MarkdownComponent, MatButton, MatIcon, MatProgressSpinner], | ||
| selector: 'discussion-summary-display', | ||
| templateUrl: '../ai-summary-display/ai-summary-display.component.html' | ||
| }) | ||
| export class DiscussionSummaryDisplayComponent extends AiSummaryDisplayComponent { | ||
| protected getSystemPrompt(prompt: string): string { | ||
| return `You are a teacher who is summarizing students' discussion threads, which include posts and replies to the following question: "${prompt}". | ||
| Each thread is in the format: <thread><post>Post</post><replies><reply>Reply 1</reply><reply>Reply 2</reply></replies></thread>. | ||
| In the same language as the question, provide a summary of the threads in 100 words or less.`; | ||
| } | ||
|
|
||
| protected getStudentResponses(): string { | ||
| return this.getDiscussionThreads().reduce( | ||
| (soFar, thread) => | ||
| `${soFar}<thread><post>${thread.post}</post><replies>${thread.replies.map((reply) => `<reply>${reply}</reply>`).join('')}</replies></thread>`, | ||
| '' | ||
| ); | ||
| } | ||
|
|
||
| private getDiscussionThreads(): Thread[] { | ||
| const threads = this.latestComponentStates | ||
| .filter((state) => state.studentData.componentStateIdReplyingTo == null) | ||
| .map((post) => ({ id: post.id, post: post.studentData.response, replies: [] })); | ||
| this.latestComponentStates | ||
| .filter((state) => state.studentData.componentStateIdReplyingTo != null) | ||
| .forEach((reply) => { | ||
| threads | ||
| .find((t) => t.id === reply.studentData.componentStateIdReplyingTo) | ||
| ?.replies.push(reply.studentData.response); | ||
| }); | ||
| return threads; | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.