-
Notifications
You must be signed in to change notification settings - Fork 5
feat(Authoring Tool): Drag and drop lessons and steps #2288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hirokiterashima
wants to merge
12
commits into
develop
Choose a base branch
from
project-authoring-drag-drop-mode
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
430f102
Add batchEditMode and implement drag/drop to reorder active lessons
hirokiterashima a226911
Drag and drop lessons and steps work, saves, and updates node position
hirokiterashima df962fb
Fix issue dragging middle step to anther lesson was breaking transition
hirokiterashima bbb9245
Fix issue: moving inactive lesson -> active when no active lesson did…
hirokiterashima b2a7492
Don't allow author to move branching step
hirokiterashima 38c760e
Drag step between active and inactive steps
hirokiterashima 03bb198
Add cdkDropListEnterPredicate to fine-control allowable drags
hirokiterashima 8fa68ce
Clean up: remove debug outs from UI
hirokiterashima c4a25f8
Extract common code to this.projectService.getAllGroupIds();
hirokiterashima f508838
Clean up code
hirokiterashima fa4e567
Fixed tests, generated messages
hirokiterashima d794ba0
Don't allow a step to be dropped in the first step of a first path in…
hirokiterashima File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
4 changes: 2 additions & 2 deletions
4
...authoringTool/choose-node-location/node-icon-and-title/node-icon-and-title.component.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| <div class="flex flex-row justify-start items-center gap-1"> | ||
| <node-icon [nodeId]="nodeId" size="18" /> | ||
| @if (showPosition) { | ||
| <span class="step-number">{{ getNodePosition(nodeId) }}: </span> | ||
| <span class="step-number">{{ nodePosition }}: </span> | ||
| } | ||
| <span class="step-title">{{ getNodeTitle(nodeId) }}</span> | ||
| <span class="step-title">{{ nodeTitle }}</span> | ||
| </div> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function with many parameters (count = 7): constructor [qlty:function-parameters]