This repository was archived by the owner on Sep 4, 2020. It is now read-only.
Issue #181 - Adding first pass of File that can create new test files#182
Open
jpsider wants to merge 2 commits intoWahlNetwork:masterfrom
Open
Issue #181 - Adding first pass of File that can create new test files#182jpsider wants to merge 2 commits intoWahlNetwork:masterfrom
jpsider wants to merge 2 commits intoWahlNetwork:masterfrom
Conversation
… test files based on an input object.
Contributor
|
First, much love for the submission! Really appreciate that we have some hard code to consider, and the time you spent to help. I'm attempting to open discussion in #102, based on considerations and context that comes to mind for me. The first thing that stands out is we may need to retain the name |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation is hardcoded with Get-AdvancedSetting, which I think could be easily updated to a parameter. I'm interested in some feedback to see if this is something to move forward with, or it generates too much data.