Add date-based partitioning to parquet file paths#6
Merged
Conversation
Co-authored-by: xDarksome <22872975+xDarksome@users.noreply.github.com>
…stamp format Co-authored-by: xDarksome <22872975+xDarksome@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update key suffix format for parquet files
Add date-based partitioning to parquet file paths
Feb 3, 2026
xDarksome
requested changes
Feb 3, 2026
|
|
||
| ``` | ||
| /data/<prefix>/<metric name>/2024022021.parquet | ||
| /data/<YYYY-MM-DD>/<prefix>/<metric name>/20240220211430.parquet |
Member
There was a problem hiding this comment.
prefix should be before the date
Author
There was a problem hiding this comment.
Fixed in 7ac4619. The path structure now correctly places the prefix before the date: /data/<prefix>/<YYYY-MM-DD>/<metric name>/timestamp.parquet
Co-authored-by: xDarksome <22872975+xDarksome@users.noreply.github.com>
Co-authored-by: xDarksome <22872975+xDarksome@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
YYYY-MM-DDdate prefix to parquet file key structure for date-based partitioning.Changes
createBackendWriter()to insert date between prefix and metric name usingstrings.LastIndex()to split the pathPath Structure
The implementation correctly places the prefix before the date, inserting the date between the prefix portion and the metric name. This enables date-based S3 lifecycle policies and simplifies retention management while maintaining the prefix structure.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.