refactor: migrate from custom bitmask to EnumerableSet architecture#217
Closed
rplusq wants to merge 1 commit into
Closed
refactor: migrate from custom bitmask to EnumerableSet architecture#217rplusq wants to merge 1 commit into
rplusq wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a follow-up PR on top of @xDarksome #212. My goal was to keep Rust/WCN integration almost unchanged while modernising the Solidity internals.
What changed (one-liner each)
Integration side of things
@xDarksome : please confirm events + getters still fit alloy bindings. No single getView() now, so you might have to join with multiCall on the alloy side: https://alloy.rs/guides/multicall#multicall-with-alloy
All forge tests green; ready for merge once you’re happy.