feat: Storage API 2.0#220
Merged
Merged
Conversation
…n into feat/contract
…n into feat/contract
…n into feat/contract
…n into feat/contract
heilhead
approved these changes
Jun 30, 2025
nopestack
reviewed
Jul 1, 2025
| #[derive(Clone, Debug, From, EnumDiscriminants, PartialEq, Eq)] | ||
| #[strum_discriminants(name(Name))] | ||
| #[strum_discriminants(derive(Ordinalize))] | ||
| pub enum Operation<'a> { |
There was a problem hiding this comment.
I thought we were simplifying type signatures with this one
Member
Author
There was a problem hiding this comment.
Is a single parameter too complex? I was talking about lifetimes in RPC machinery impls.
heilhead
approved these changes
Jul 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
New version of Storage API for WCN 2.0
Additionally:
How Has This Been Tested?
Unit
Due Diligence