fix: disable throttled error#221
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR disables the throttled error handling to prevent potential memory issues during system stalls. Key changes include:
- Removal of throttled error handling logic in the QUIC server.
- Elimination of the THROTTLED constant in the RPC error definition.
- Simplification of the pulse monitor's run function signature by removing the unnecessary mutable binding.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| crates/rpc/src/quic/server.rs | Removed throttled error handling logic in connections. |
| crates/rpc/src/lib.rs | Removed the THROTTLED constant from the Error struct. |
| crates/pulse_monitor/src/lib.rs | Adjusted run function signature for clarity. |
Comments suppressed due to low confidence (2)
crates/rpc/src/quic/server.rs:220
- Consider adding a comment explaining the decision to skip sending the throttled error to improve future maintainability.
continue;
crates/rpc/src/lib.rs:214
- Ensure that all references to the THROTTLED constant are updated or removed from documentation and other parts of the codebase, as it's no longer used.
const THROTTLED: Self = Self::new(error_code::THROTTLED);
| // Note: Requires a stream that would immediately yield the initial cluster | ||
| // state. | ||
| pub async fn run<C>(mut cluster_stream: C) | ||
| pub async fn run<C>(cluster_stream: C) |
There was a problem hiding this comment.
Removing the mutable binding for cluster_stream improves clarity; verify that mutable access is not required within the function.
xDarksome
approved these changes
Jun 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This disables the 'throttled' error, as it's possible that it can eat a lot of memory during system stall.
How Has This Been Tested?
Not tested.
Due Diligence