Skip to content

feat(infra): update prom2parquet#321

Merged
xDarksome merged 1 commit into
mainfrom
feat/infra-update-prom2parquet
Feb 4, 2026
Merged

feat(infra): update prom2parquet#321
xDarksome merged 1 commit into
mainfrom
feat/infra-update-prom2parquet

Conversation

@xDarksome

Copy link
Copy Markdown
Member

Description

Updates to the latest prom2parquet version supporting datetime prefix

How Has This Been Tested?

Not tested

Due Diligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

@claude

claude Bot commented Feb 3, 2026

Copy link
Copy Markdown

Claude finished @xDarksome's task in 42s —— View job


Review Complete

  • Read changed files
  • Analyze version update
  • Perform automated security checks
  • Report findings

Findings

⚠️ Untested Infrastructure Change
File: infra/testnet/main.tf:95
Issue: PR description states "Not tested" for a production infrastructure change updating prom2parquet from sha-1fee3c3 to sha-0cd5c42.
Recommendation: Infrastructure changes should be tested before deployment. Verify that the new version with datetime prefix support works correctly in a non-production environment first. Consider:

  • Testing the image can be pulled successfully
  • Validating datetime prefix functionality works as expected
  • Confirming backward compatibility with existing metrics export pipeline
  • Checking S3 bucket permissions remain valid for new version

⚠️ SHA-based Versioning Without Context
File: infra/testnet/main.tf:95
Issue: Using commit SHA tags (sha-0cd5c42) makes it difficult to understand what changed between versions without additional context.
Recommendation: Consider adding a comment explaining the key changes in this version (e.g., "Updated to support datetime prefix in S3 exports") or reference a changelog/release notes URL if available. This helps with maintainability and troubleshooting.


@xDarksome xDarksome requested a review from mario-reown February 4, 2026 13:32
@xDarksome xDarksome merged commit a4ee116 into main Feb 4, 2026
13 checks passed
@xDarksome xDarksome deleted the feat/infra-update-prom2parquet branch February 4, 2026 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants