You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
⚠️Untested Infrastructure Change File: infra/testnet/main.tf:95 Issue: PR description states "Not tested" for a production infrastructure change updating prom2parquet from sha-1fee3c3 to sha-0cd5c42. Recommendation: Infrastructure changes should be tested before deployment. Verify that the new version with datetime prefix support works correctly in a non-production environment first. Consider:
Testing the image can be pulled successfully
Validating datetime prefix functionality works as expected
Confirming backward compatibility with existing metrics export pipeline
Checking S3 bucket permissions remain valid for new version
⚠️SHA-based Versioning Without Context File: infra/testnet/main.tf:95 Issue: Using commit SHA tags (sha-0cd5c42) makes it difficult to understand what changed between versions without additional context. Recommendation: Consider adding a comment explaining the key changes in this version (e.g., "Updated to support datetime prefix in S3 exports") or reference a changelog/release notes URL if available. This helps with maintainability and troubleshooting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates to the latest prom2parquet version supporting datetime prefix
How Has This Been Tested?
Not tested
Due Diligence