Skip to content

Conversation

@dd23
Copy link
Contributor

@dd23 dd23 commented Mar 11, 2025

This PR does the following:

  • updates minimum Rust version to 1.70, as needed by some dependencies - this made CI fail
  • removes the custom impl of Eq and PartialEq and instead derives them (similar to Hash) to avoid this Clippy warning
  • fixes Clippy warnings re lifetimes that show up in more recent Rust versions

Copy link
Owner

@WanzenBug WanzenBug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! I don't want to bump the MSRV if we don't have to, so I'd rahter fix the CI workflow than bumping it.

g2gen/Cargo.toml Outdated
categories = [ "no-std", "algorithms" ]
keywords = [ "finite-field", "galois", "macro", "newtype"]
rust-version = "1.61"
rust-version = "1.70"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cargo +1.61.0 check

Runs just fine. Issue seems to be running cargo +1.61.0 test, which I'd say can be ignored. I guess that means the CI setup should be updated so it only runs check in the MSRV case.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case, I think we need to pin dependencies to an older version, cause I get

error: package textwrap v0.16.2 cannot be built because it requires rustc 1.70 or newer, while the currently active rustc version is 1.61.0

when trying to run the tests with cargo +1.61.0 test

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. the dev-dependecies are no longer compatible with 1.61.0. So you cannot run cargo +1.61.0 test. But you can still run cargo +1.61.0 check. So g2p will run just fine with the older rust version, it's just that we can't test it with the current tests :/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a Cargo.lock file, with dependencies set to versions that are compatible with 1.61. With this the tests should work fine when run with cargo +1.61.0 test

Copy link
Owner

@WanzenBug WanzenBug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thank you!

@WanzenBug WanzenBug merged commit 3a3b608 into WanzenBug:master Mar 12, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants