[Experimental] Improve plugin startup validation and type safety#516
Draft
ZoogieZork wants to merge 1 commit intomainfrom
Draft
[Experimental] Improve plugin startup validation and type safety#516ZoogieZork wants to merge 1 commit intomainfrom
ZoogieZork wants to merge 1 commit intomainfrom
Conversation
This is the start of overhauling how plugins start up to be typesafe both during development and at runtime, which will open paths forward to safely make larger changes to the engine <-> plugin protocol. * Define typehints for args. * Document usage and restrictions. * Add runtime logging if JSON decoding fails.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This is an experimental branch to explore options and progressively make improvements.
This PR is for verifying CI checks -- individual changes will be cherry-picked into separate PRs.
Description
This is the start of overhauling how plugins start up to be typesafe both during development and at runtime, which will open paths forward to safely make larger changes to the engine <-> plugin protocol.
Motivation and Context
Ensure that the communication between the engine and plugins is well-defined, typesafe (both static analysis and at runtime) so that we can start evolving the plugin architecture.
How Has This Been Tested?
Testing focused using the
plugin_runnerutility.Types of changes
Checklist