Conversation
…ult (#549) * Upgrade to pytest-cov v7. * Don't print coverage report by default. Removes the textual coverage report by default since it fills up the screen when just trying to run unit tests. The HTML coverage report is still generated, which is generally a more useful format anyway.
* update trivy to 0.67.0 * update trivy version * use empty object to avoid calling NoneType.get
Bumps the actions group with 1 update: [actions/cache](https://github.com/actions/cache). Updates `actions/cache` from 4.2.4 to 4.3.0 - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@0400d5f...0057852) --- updated-dependencies: - dependency-name: actions/cache dependency-version: 4.3.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: actions ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
| "@date-io/luxon": "^3.2.0", | ||
| "@emotion/react": "^11.14.0", | ||
| "@emotion/styled": "^11.14.1", | ||
| "@fontsource/roboto": "^5.2.8", |
There was a problem hiding this comment.
Moved from deprecated roboto to current.
| import { InputBaseProps } from "@mui/material"; | ||
|
|
||
| // Formik wrapper for Material UI date/time pickers | ||
| // adapted from Material-UI picker Formik sample: |
There was a problem hiding this comment.
Removed broken linkl
| field, | ||
| form, | ||
| getShouldDisableDateError, | ||
| onChange, |
There was a problem hiding this comment.
This was never used.
| const inputProps: InputBaseProps["inputProps"] = { | ||
| id: props.id, | ||
| title: displayValue, | ||
| "data-testid": `${field.name}_date_input`, |
There was a problem hiding this comment.
Added a testid to the input, the date field is no longer a single input, but it added a hidden input field to show the date, using this on tests.
| await user.type(expiresField, "testme!"); | ||
| }); | ||
| await waitFor(() => { | ||
| expect(expiresField).toHaveValue("YYYY/MM/DD hh:mm"); // can't type invalid chars in field |
There was a problem hiding this comment.
The input no longer has a value for the placeholder.
ZoogieZork
left a comment
ZoogieZork
left a comment
There was a problem hiding this comment.
Looks good, just had a couple questions.
ui/src/components/EnhancedTable.tsx
Outdated
| const newLastPage = Math.max(0, Math.ceil(count / rowsPerPage) - 1); | ||
|
|
||
| let showPage = page; | ||
| if (newLastPage < page) { | ||
| showPage = 0; | ||
| } |
There was a problem hiding this comment.
Is this is a change in behavior or replicating the old behavior of MUI 8?
There was a problem hiding this comment.
This fixes a warning that I was getting locally, but realized the warning is supposed to be there as part of the test (but only on dev) so I removed it.
| const AllTheProviders = ({ children }: AllTheProvidersProps) => { | ||
| const locale = "en"; | ||
| i18n.load(locale, enMessages); | ||
| i18n.activate(locale); | ||
| const locale = "en"; | ||
| i18n.load(locale, enMessages); | ||
| i18n.activate(locale); | ||
|
|
||
| const AllTheProviders = ({ children }: AllTheProvidersProps) => { |
There was a problem hiding this comment.
Was this initialization moved out due to a race condition or some other reason? If so, would be good to add a comment documenting the reasons so it doesn't accidentally get reverted.
There was a problem hiding this comment.
I tried to figure out why I moved this, and I can't. Moving it back.
4 participants
Upgrade to MUI 8
How Has This Been Tested?
Tested locally and in nonprod
Lots of changes, but most of them are pretty similar in several files.
Types of changes
Checklist