Refactor interface -> any, new errors format etc#54
Open
piotrrojek wants to merge 5 commits intomasterfrom
Open
Refactor interface -> any, new errors format etc#54piotrrojek wants to merge 5 commits intomasterfrom
piotrrojek wants to merge 5 commits intomasterfrom
Conversation
Contributor
Author
|
Looks like after upgrading the linter caught more issues. Will update it. |
Contributor
Author
|
Looks like switching to standard library errors uncovered lots of linting issues covered previously by custom package. Minor things, but it'll be consistent with the rest of the codebase now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR to update Go version this library relies on, swapped interface{} with any, replaced github.com/pkg/errors with standard library new errors syntax, updated go.mod etc.
Need to test it first, because I've seen attempts of upgrading in the repo tree, but it was reverted: a54d2b2