Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the new rust compiler target for wasm #262

Closed
wants to merge 2 commits into from
Closed

Conversation

alabulei1
Copy link
Collaborator

@alabulei1 alabulei1 commented Jan 10, 2025

Explanation

the wasm32-wasi target is being renamed to wasm32-wasip1 and the wasm32-wasi target will be removed from nightly in October 2024 and removed from stable Rust in January 2025.

Related issue

What type of PR is this

Proposed Changes

Update the new rust compiler

Copy link
Member

juntao commented Jan 10, 2025

Hello, I am a PR summary agent on flows.network. Here are my reviews of code commits in this PR.


Overall Summary

Potential Issues and Errors

  • Consistency: While the change is consistent across multiple documentation files, it's crucial to ensure that every reference to wasm32-wasi has been updated. Missed updates could lead to confusion or build errors.

  • Build Path Changes: The change in build paths from target/wasm32-wasi/release/... to target/wasm32-wasip1/release/... must be verified to ensure that all scripts and automated processes still function correctly.

  • Testing Across Platforms: Given the change in the target, it's essential to test the examples and setups on different platforms to confirm compatibility. This includes both local development environments and CI pipelines.

Most Important Findings

  • Primary Target Update: The PR successfully updates the Rust compiler target from wasm32-wasi to wasm32-wasip1 in multiple documentation files, reflecting an important shift towards a more standardized WASM compilation environment.

  • Path Adjustments: All specified build output paths have been updated accordingly, ensuring that future builds direct their outputs correctly.

  • Verification Required: It is imperative to run through the examples and test setups to verify functionality with wasm32-wasip1, especially considering it may differ from wasm32-wasi.

Action Items

  • Build Output Review: Verify that all build commands place their output in the new directories (target/wasm32-wasip1/).

  • Thorough Testing: Test examples and setups on various platforms to ensure they compile and execute as expected.

  • Documentation Accuracy: Confirm that all documentation is clear, accurate, and up-to-date with the wasm32-wasip1 target.

Details

Commit 4f6438b005abcd4f20a5b5ffa72d4d7acb14c4ad

Key Changes Summary

  1. Update Compiler Target: The PR updates the Rust compiler target from wasm32-wasi to wasm32-wasip1 across numerous documentation files.

    • Affected Files: 78 documentation files covering various Rust and WebAssembly-related examples, setups, and guides.

Important Findings

  • Consistency: The primary change is consistent across multiple files, ensuring that the new target (wasm32-wasip1) is used uniformly.

  • Path Updates: Each instance where the build output path was specified (e.g., target/wasm32-wasi/release/...) has been updated to target/wasm32-wasip1/release/....

  • Verification Needed: Ensure that all examples and setups still work as expected with the new target. Testing the changes on different platforms is recommended.

Action Items

  • Review Build Outputs: Verify that the build outputs are correctly placed in the new directories (target/wasm32-wasip1/).

  • Testing: Run through some of the examples to ensure they compile and execute as expected with wasm32-wasip1.

  • Documentation Check: Confirm that the documentation is clear and accurate regarding the update to wasm32-wasip1.

Commit 7ebe201c1523b5e30b16af538bb051b26a7bd3da

-Key Changes Summary:

  1. Updated Rust Compiler Target: Changed the target from wasm32-wasi to wasm32-wasip1 in both the rustup target add and cargo build --release --target commands.
  2. Documentation Update Location: The changes were made in the cli.md file within the Android contribution documentation, specifically at line 79.

Most Important Finding: The patch updates the Rust compiler target from wasm32-wasi to wasm32-wasip1, reflecting an important change in the WASM compilation process for the project.

@alabulei1 alabulei1 closed this Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants