Theme fix by Aryanryn09 · Pull Request #45 · WasmEdge/docs

Aryanryn09 · 2023-04-30T04:56:55Z

Fonts and Color Sheme updated

This commit updates the color scheme and font used throughout the application. These changes should improve the overall visual design and usability of the application, while also making it more consistent with modern design trends wrt the theme of this website with the WasmEge website

Related issue

fixes #44

Signed-off-by: Aryan <[email protected]> Signed-off-by: Aryan Bansod <[email protected]>

Bhardwaj-Himanshu · 2023-04-30T11:03:38Z

Hi @Aryanryn09,
Thank you so much for creating a pull request.
The changes are welcomed as well, but could you please also try attaching the screenshot of npm run build log with the pull request or build the project locally so that it does not throw a build error when merged as #46
Thanks!

Aryanryn09 · 2023-04-30T13:43:10Z

remote: Permission to WasmEdge/docs.git denied to Aryanryn09.
fatal: unable to access 'https://github.com/WasmEdge/docs.git/': The requested URL returned error: 403 i am getting this message what can i do to get myself unblocked

Bhardwaj-Himanshu · 2023-04-30T13:45:43Z

Could you elaborate a bit more about the error message and why are you getting it?

Inshort what are you trying to do?

Aryanryn09 · 2023-04-30T14:34:27Z

Could you elaborate a bit more about the error message and why are you getting it?

Inshort what are you trying to do?

i think i've made and deleted multiple pr's at the same time

Bhardwaj-Himanshu · 2023-04-30T17:48:01Z

Are you trying to push to the original Wasmedge repository or your forked repo?

You won't be having the permissions to push to the Wasmedge original docs repo.

alabulei1 · 2023-05-06T09:17:06Z

@Aryanryn09 LGTM! Could you fix the conflicts first? Sorry for my late reply. Because I was busy filling in more content to this doc.

Aryanryn09 · 2023-05-06T13:23:08Z

@Aryanryn09 LGTM! Could you fix the conflicts first? Sorry for my late reply. Because I was busy filling in more content to this doc.

Sure

alabulei1 · 2023-05-07T06:03:44Z

docs/develop/wasmedge/features.md


-Option #1 is to [use an OCI runtime crun](../deploy/oci-runtime/crun) (the C version of runc — mainly supported by Red Hat). crun decides whether an OCI image is Wasm or Linux based on image annotations. If the image is annotated as wasm32, crun will bypass the Linux container setup and just use WasmEdge to run it. If the image is annotated as wasm32, crun will bypass the Linux container setup and use WasmEdge to run the image. By using crun, you can get the entire Kubernetes stack - including CRI-O, containerd, Podman, kind, micro k8s, and k8s - to work with Wasm images.

-Option #2 is to [use a containerd-shim to start Wasm "containers" via runwasi](../deploy/cri-runtime/containerd.md). Basically, containerd could look at the image's target platform. It uses runwasi if the image is wasm32 and runc if it is x86 / arm. This is the approach used by Docker + Wasm.


I think we should keep Option #2.

adithyaakrishna · 2023-05-09T07:15:46Z

docs/develop/wasmedge/features.md

 WasmEdge could be seamlessly integrated with the existing cloud-native infra.

-To integrate WasmEdge with your existing cloud-native infrastructure, there are several options available for managing Wasm applications as "containers" under Kubernetes. These options enables you to run Linux containers and Wasm containers side by side within a Kubernetes cluster.
+There are several options to manage Wasm apps as "containers" under Kubernetes. All options will give you a Kubernetes cluster that runs Linux containers and WasmWasm containers side by side. 


Suggested change

There are several options to manage Wasm apps as "containers" under Kubernetes. All options will give you a Kubernetes cluster that runs Linux containers and WasmWasm containers side by side.

There are several options to manage Wasm apps as "containers" under Kubernetes. All options will give you a Kubernetes cluster that runs Linux containers and Wasm containers side by side.

adithyaakrishna · 2023-05-09T07:17:09Z

src/css/custom.css

+
+  --ifm-navbar-link-hover-color: #6495fd;
+  --ifm-footer-link-hover-color: #6495fd;
+  --ifm-menu-color-active: #20609f;
+  --ifm-link-color:#20609f;
+  --ifm-breadcrumb-color-active: #4973e8;
+  --ifm-color-primary: #c350ba;
+  --ifm-color-primary-dark: #c350ba;
+  --ifm-color-primary-darker: #c350ba;
+  --ifm-color-primary-darkest: #c350ba;
+  --ifm-color-primary-light: #c350ba;
+  --ifm-color-primary-lighter: #c350ba;
+  --ifm-color-primary-lightest: #c350ba;
  --ifm-code-font-size: 95%;
  --docusaurus-highlighted-code-line-bg: rgba(0, 0, 0, 0.1);
 }

 /* For readability concerns, you should choose a lighter palette in dark mode. */
 [data-theme='dark'] {
-  --ifm-color-primary: #25c2a0;
-  --ifm-color-primary-dark: #21af90;
-  --ifm-color-primary-darker: #1fa588;
-  --ifm-color-primary-darkest: #1a8870;
-  --ifm-color-primary-light: #29d5b0;
-  --ifm-color-primary-lighter: #32d8b4;
-  --ifm-color-primary-lightest: #4fddbf;
+  --ifm-color-primary: #d693e1;
+  --ifm-color-primary-dark: #c97fd6;
+  --ifm-color-primary-darker: #b56bca;
+  --ifm-color-primary-darkest: #a357be;
+  --ifm-color-primary-light: #e1b6ec;
+  --ifm-color-primary-lighter: #e8c3f0;
+  --ifm-color-primary-lightest: #f2dfff;


These changes are also in another PR, #51 Can we remove those changes from this PR and focus on only one change i.e. to the features.md file?

adithyaakrishna · 2023-05-13T09:59:41Z

@Aryanryn09 Could you please let us know if you have any updates on this PR?

alabulei1 · 2024-01-25T11:48:22Z

Since @Aryanryn09 didn't update this PR, I will close this PR first.

If you're ready to update the PR, please reopen it. Thanks.

Aryanryn09 added 3 commits April 30, 2023 10:15

font-colorScheme-fixed-WasmEdge#44

2f28202

Signed-off-by: Aryan <[email protected]> Signed-off-by: Aryan Bansod <[email protected]>

colorScheme-nav-WasmEdge#44

359e4dd

Signed-off-by: Aryan <[email protected]> Signed-off-by: Aryan Bansod <[email protected]>

fixes

60ae001

Signed-off-by: Aryan <[email protected]> Signed-off-by: Aryan Bansod <[email protected]>

Aryanryn09 mentioned this pull request May 1, 2023

theme-test-build #51

Closed

Merge branch 'main' into theme-fix

ceca367

alabulei1 approved these changes May 7, 2023

View reviewed changes

adithyaakrishna reviewed May 9, 2023

View reviewed changes

alabulei1 closed this Jan 25, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Theme fix#45

Theme fix#45
Aryanryn09 wants to merge 4 commits intoWasmEdge:mainfrom
Aryanryn09:theme-fix

Aryanryn09 commented Apr 30, 2023

Uh oh!

Bhardwaj-Himanshu commented Apr 30, 2023

Uh oh!

Aryanryn09 commented Apr 30, 2023

Uh oh!

Bhardwaj-Himanshu commented Apr 30, 2023

Uh oh!

Aryanryn09 commented Apr 30, 2023

Uh oh!

Bhardwaj-Himanshu commented Apr 30, 2023

Uh oh!

alabulei1 commented May 6, 2023

Uh oh!

Aryanryn09 commented May 6, 2023

Uh oh!

alabulei1 May 7, 2023

Uh oh!

adithyaakrishna May 9, 2023

Uh oh!

adithyaakrishna May 9, 2023

Uh oh!

adithyaakrishna commented May 13, 2023

Uh oh!

alabulei1 commented Jan 25, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants


		Option #1 is to [use an OCI runtime crun](../deploy/oci-runtime/crun) (the C version of runc — mainly supported by Red Hat). crun decides whether an OCI image is Wasm or Linux based on image annotations. If the image is annotated as wasm32, crun will bypass the Linux container setup and just use WasmEdge to run it. If the image is annotated as wasm32, crun will bypass the Linux container setup and use WasmEdge to run the image. By using crun, you can get the entire Kubernetes stack - including CRI-O, containerd, Podman, kind, micro k8s, and k8s - to work with Wasm images.

		Option #2 is to [use a containerd-shim to start Wasm "containers" via runwasi](../deploy/cri-runtime/containerd.md). Basically, containerd could look at the image's target platform. It uses runwasi if the image is wasm32 and runc if it is x86 / arm. This is the approach used by Docker + Wasm.

	There are several options to manage Wasm apps as "containers" under Kubernetes. All options will give you a Kubernetes cluster that runs Linux containers and WasmWasm containers side by side.
	There are several options to manage Wasm apps as "containers" under Kubernetes. All options will give you a Kubernetes cluster that runs Linux containers and Wasm containers side by side.

Comments

Conversation

Aryanryn09 commented Apr 30, 2023

Fonts and Color Sheme updated

Related issue

Uh oh!

Bhardwaj-Himanshu commented Apr 30, 2023

Uh oh!

Aryanryn09 commented Apr 30, 2023

Uh oh!

Bhardwaj-Himanshu commented Apr 30, 2023

Uh oh!

Aryanryn09 commented Apr 30, 2023

Uh oh!

Bhardwaj-Himanshu commented Apr 30, 2023

Uh oh!

alabulei1 commented May 6, 2023

Uh oh!

Aryanryn09 commented May 6, 2023

Uh oh!

alabulei1 May 7, 2023

Choose a reason for hiding this comment

Uh oh!

adithyaakrishna May 9, 2023

Choose a reason for hiding this comment

Uh oh!

adithyaakrishna May 9, 2023

Choose a reason for hiding this comment

Uh oh!

adithyaakrishna commented May 13, 2023

Uh oh!

alabulei1 commented Jan 25, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants