Fix get default outbound interface on iOS #970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the default outbound interface selection logic on iOS by reordering interface priorities and improving the sorting algorithm. The change prioritizes wired connections over wireless, wireless over cellular, and cellular over VPN interfaces to ensure optimal routing.
- Reordered interface priority array to prefer wired (eth, Ethernet) over wireless (WLAN, Wi-Fi) over cellular (pdp_ip, rmnet, ccmni) over VPN (Tailscale)
- Added comprehensive comments documenting interface name patterns for different platforms
- Refactored sorting logic to prioritize by interface type first, then IPv6 availability, then IPv6 global unicast, and finally alphabetical order
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
Please provide a PR comment explaining the new logic and fix the cargo fmt issue. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.