-
Notifications
You must be signed in to change notification settings - Fork 1
[release] 진행상황을 main으로 머지 #176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
15dc5f8
Merge remote-tracking branch 'origin/develop' into feature/hyoin
hyoinYang bad8822
[fix] 버스 정보 출력시 공공 데이터 api 사용
hyoinYang 8e2a156
[refactor] 쿼리 최적화, 메모리 정리
hyoinYang 69b82a0
[fix] 공공데이터 api 호출시 webclient 사용
hyoinYang a0b8988
[fix] 지하철 정보가 안 뜨는 문제 해결
hyoinYang eedade7
[refactor] api 응답 로그 정리 및 속도 개선
hyoinYang f079f3a
[refactor] 불필요한 api 호출 삭제
hyoinYang 8242123
[refactor] 버스 api에 더미데이터 사용
hyoinYang 341f573
[refactor] projection interface 추가
hyoinYang 98962d3
[refactor] N+1 방지를 위해 VO 사용
hyoinYang 1305b1c
Merge pull request #175 from Wayble-Project/feature/hyoin
hyoinYang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 changes: 21 additions & 0 deletions
21
src/main/java/com/wayble/server/direction/dto/InternalStep.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| package com.wayble.server.direction.dto; | ||
|
|
||
| import java.util.List; | ||
|
|
||
| import com.wayble.server.direction.dto.response.TransportationResponseDto; | ||
| import com.wayble.server.direction.entity.type.DirectionType; | ||
|
|
||
| // 대중교통 길찾기에 사용하기 위한 내부용 DTO | ||
| public record InternalStep( | ||
| DirectionType mode, | ||
| List<TransportationResponseDto.MoveInfo> moveInfo, | ||
| String routeName, | ||
| Integer moveNumber, | ||
| TransportationResponseDto.BusInfo busInfo, | ||
| TransportationResponseDto.SubwayInfo subwayInfo, | ||
| String from, | ||
| String to, | ||
| Long routeId, | ||
| NodeRef startNode, | ||
| NodeRef endNode | ||
| ) {} | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| package com.wayble.server.direction.dto; | ||
|
|
||
| public record NodeRef( | ||
| Long id, | ||
| String stationName, | ||
| Double latitude, | ||
| Double longitude | ||
| ) {} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 changes: 18 additions & 0 deletions
18
src/main/java/com/wayble/server/direction/repository/EdgeBoundingBoxProjection.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| package com.wayble.server.direction.repository; | ||
|
|
||
| import com.wayble.server.direction.entity.type.DirectionType; | ||
|
|
||
| public interface EdgeBoundingBoxProjection { | ||
| Long getEdgeId(); | ||
| Long getStartNodeId(); | ||
| Long getEndNodeId(); | ||
| DirectionType getEdgeType(); | ||
| String getStartStationName(); | ||
| Double getStartLatitude(); | ||
| Double getStartLongitude(); | ||
| String getEndStationName(); | ||
| Double getEndLatitude(); | ||
| Double getEndLongitude(); | ||
| Long getRouteId(); | ||
| String getRouteName(); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 11 additions & 0 deletions
11
src/main/java/com/wayble/server/direction/repository/NodeBoundingBoxProjection.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| package com.wayble.server.direction.repository; | ||
|
|
||
| import com.wayble.server.direction.entity.type.DirectionType; | ||
|
|
||
| public interface NodeBoundingBoxProjection { | ||
| Long getId(); | ||
| String getStationName(); | ||
| DirectionType getNodeType(); | ||
| Double getLatitude(); | ||
| Double getLongitude(); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 5 additions & 0 deletions
5
src/main/java/com/wayble/server/direction/repository/RouteRepository.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,14 @@ | ||
| package com.wayble.server.direction.repository; | ||
|
|
||
| import org.springframework.data.jpa.repository.JpaRepository; | ||
| import org.springframework.data.jpa.repository.Query; | ||
| import org.springframework.data.repository.query.Param; | ||
|
|
||
| import com.wayble.server.direction.entity.transportation.Route; | ||
| import java.util.Optional; | ||
|
|
||
| public interface RouteRepository extends JpaRepository<Route, Long>{ | ||
|
|
||
| @Query("SELECT r.routeName FROM Route r WHERE r.routeId = :routeId") | ||
| Optional<String> findRouteNameById(@Param("routeId") Long routeId); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
null 허용 필드에 @nullable 명시 필요 (NPE 방지, 가독성 향상)
WALK/환승 등에서
moveInfo,busInfo,subwayInfo,routeId,startNode,endNode가 null로 사용됩니다. 내부 DTO라도 null 가능성을 타입 시그니처로 드러내면 후속 사용처에서 방어 코드가 단순해지고 리팩터 시 안전합니다.아래와 같이 명시를 제안합니다.
📝 Committable suggestion
🤖 Prompt for AI Agents