-
Notifications
You must be signed in to change notification settings - Fork 1
[refactor] 로그인/회원가입 구현 관련 리팩토링 진행 #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
67fab41
[fix] 유저 엔티티 email+loginType 복합 unique로 변경
seung-in-Yoo 82a0dd2
[fix] email + loginType 기준으로 조회하도록 변경
seung-in-Yoo a3e3a51
[fix] email + loginType 기준으로 서비스 로직 변경
seung-in-Yoo b9f18d4
[fix] UserLoginRequestDto에 loginType 추가
seung-in-Yoo 1115815
[fix] 소셜/일반 계정 구분을 위해 로그인에 email+loginType 조회 적용
seung-in-Yoo 8a8e64f
[refactor] 토큰이 유효하지 않거나 없으면 SecurityContext 초기화하도록 리팩토링
seung-in-Yoo d63bd83
[refactor] JWT 필터 및 토큰 관련 보안 및 성능 개선 리팩토링
seung-in-Yoo 6adb750
[fix] JWT 토큰 subject를 email에서 userId로 변경
seung-in-Yoo b7af737
[refactor] CodeRabbit 리뷰 기반 리팩토링 진행 (JWT 토큰 키 생성 방식 개선)
seung-in-Yoo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 3 additions & 3 deletions
6
src/main/java/com/wayble/server/user/repository/UserRepository.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,13 @@ | ||
| package com.wayble.server.user.repository; | ||
|
|
||
| import com.wayble.server.user.entity.LoginType; | ||
| import com.wayble.server.user.entity.User; | ||
| import org.springframework.data.jpa.repository.JpaRepository; | ||
|
|
||
| import java.util.Optional; | ||
|
|
||
| public interface UserRepository extends JpaRepository<User, Long> { | ||
|
|
||
| Optional<User> findByEmail(String email); | ||
|
|
||
| boolean existsByEmail(String email); | ||
| boolean existsByEmailAndLoginType(String email, LoginType loginType); | ||
| Optional<User> findByEmailAndLoginType(String email, LoginType loginType); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.