Add support for global menus #2576
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkondor
force-pushed
the
global_menu2
branch
from
6b7441c to
e2b059d
Compare
This allows apps to link their implementation of the com.canonical.dbusmenu DBus interface to their open views, implementing global menus.
Note: this requires an update to the protocol and wlroots. This forwards the information received by the KDE AppMenu and GTK Shell protocols using the proposed extension to wlr-foreign-toplevel that allows forwarding information about DBus interfaces.
dkondor
force-pushed
the
global_menu2
branch
from
334e042 to
1e630e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://gitlab.freedesktop.org/wlroots/wlr-protocols/-/merge_requests/131
Requires also https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/4986
Test program: https://github.com/dkondor/gtk_global_menu_test
This implements the proposed changes to
wlr-foreign-toplevel-managemen+ also implements the KDE AppMenu protocol.