-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ported to GTK4 #290
Open
trigg
wants to merge
52
commits into
WayfireWM:master
Choose a base branch
from
trigg:gtk4
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Ported to GTK4 #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update from upstream
- - Almost everything is broken. - - This is expected
- - This is insane. - - No, how is this even usable - - Well whatever. - - Someone please valgrind because I'm sure there's lots of bad ideas here.
- Some changes to SNI dbusmenu - Getting occassional segfaults in SNI dbusmenu so these need a better read-through before calling it
- - Still inherently broken until dbusmenu-glib reports a type back
- Dock takes entire width but sets itself to click-through on the outside - Switched panel to using CenterBox which does a better job than my implementation - Moved CSS dir loading into base app class
- First attempt at output changes
- Output hot plugging sorted. - - This will need testing by people with more than 1 external monitor to see if there's any unknowns.
- Add an option to animate icons removed from dock - Added to default dock CSS
- Fixed rectangle hints in dock and panel - Fixed volume scrolling
- Fixed changing fill type in background triggering a new image load - Remove GTK interactive debugging
- Fixed volume scroll on icon
…erms, recreate what we want from parts
- Remove MenuButton from volume and switched to a menu with a button.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extensive changes to bring the code base up to working on GTK4.
Dependencies:
Material changes overview:
icon_size
options have been fed into CSS Styles that are generated & updated from config17px
1.2em
0.9rem
While I was in the area:
I'm sure there's more, and will edit this as and when possible.
I look forward to uncrustify.