[Strings] Erase the strings section after StringLifting #7546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlively
approved these changes
Apr 23, 2025
src/passes/StringLifting.cpp
Outdated
| json::Value array; | ||
| array.parse(copy.data(), json::Value::WTF16); | ||
| if (!array.isArray()) { | ||
| auto iter = std::find_if( |
There was a problem hiding this comment.
Unlike most variables holding iterators, this one is live for a nontrivial length of code. Let's give it a name like stringSectionIter so the reader remembers what it is by the time they get down to line 120.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After we lift the strings section into stringref, we don't need the section any
more, and leaving it around could cause problems with repeated lifting/
lowering operations (which would be very much possible with #7540). In
particular, without erasing it, we'd accumulate such sections over time.
Diff without whitespace is smaller.