CABI: move the call state out of the event-code enum and into the payload #500
+51
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcrichton
approved these changes
Apr 10, 2025
alexcrichton
added a commit
to alexcrichton/wit-bindgen
that referenced
this pull request
Apr 15, 2025
alexcrichton
added a commit
to alexcrichton/wit-bindgen
that referenced
this pull request
Apr 15, 2025
github-merge-queue bot
pushed a commit
to bytecodealliance/wit-bindgen
that referenced
this pull request
Apr 15, 2025
alexcrichton
added a commit
to alexcrichton/wasip3-prototyping
that referenced
this pull request
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in #492. This was a pretty simple change and also nicely avoids the coupling between the two enums (e.g., if we need to add more values to
CallState).