This repository was archived by the owner on Apr 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 84
Expand tests for array.new_data
#562
Merged
rossberg
merged 4 commits into
WebAssembly:main
from
fitzgen:test-for-out-of-bounds-array-new-data
Sep 28, 2024
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,68 @@ | ||
(module | ||
(type $arr (array (mut i8))) | ||
|
||
(data $d "abcd") | ||
|
||
(func (export "array-new-data") (param i32 i32) (result (ref $arr)) | ||
(array.new_data $arr $d (local.get 0) (local.get 1)) | ||
) | ||
) | ||
|
||
;; In-bounds data segment accesses. | ||
(assert_return (invoke "array-new-data" (i32.const 0) (i32.const 0)) (ref.array)) | ||
(assert_return (invoke "array-new-data" (i32.const 0) (i32.const 4)) (ref.array)) | ||
(assert_return (invoke "array-new-data" (i32.const 1) (i32.const 2)) (ref.array)) | ||
(assert_return (invoke "array-new-data" (i32.const 4) (i32.const 0)) (ref.array)) | ||
|
||
;; Out-of-bounds data segment accesses. | ||
(assert_trap (invoke "array-new-data" (i32.const 0) (i32.const 5)) "out of bounds memory access") | ||
(assert_trap (invoke "array-new-data" (i32.const 5) (i32.const 0)) "out of bounds memory access") | ||
(assert_trap (invoke "array-new-data" (i32.const 1) (i32.const 4)) "out of bounds memory access") | ||
(assert_trap (invoke "array-new-data" (i32.const 4) (i32.const 1)) "out of bounds memory access") | ||
|
||
|
||
(module | ||
(type $arr (array (mut i8))) | ||
|
||
(data $d "\aa\bb\cc\dd") | ||
|
||
(func (export "array-new-data-contents") (result i32 i32) | ||
(local (ref $arr)) | ||
(local.set 0 (array.new_data $arr $d (i32.const 1) (i32.const 2))) | ||
(array.get_u $arr (local.get 0) (i32.const 0)) | ||
(array.get_u $arr (local.get 0) (i32.const 1)) | ||
) | ||
) | ||
|
||
;; Array is initialized with the correct contents. | ||
(assert_return (invoke "array-new-data-contents") (i32.const 0xbb) (i32.const 0xcc)) | ||
|
||
(module | ||
(type $arr (array (mut i32))) | ||
|
||
(data $d "\aa\bb\cc\dd") | ||
|
||
(func (export "array-new-data-little-endian") (result i32) | ||
(array.get $arr | ||
(array.new_data $arr $d (i32.const 0) (i32.const 1)) | ||
(i32.const 0)) | ||
) | ||
) | ||
|
||
;; Data segments are interpreted as little-endian. | ||
(assert_return (invoke "array-new-data-little-endian") (i32.const 0xddccbbaa)) | ||
fitzgen marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
(module | ||
(type $arr (array (mut i16))) | ||
|
||
(data $d "\00\11\22") | ||
|
||
(func (export "array-new-data-unaligned") (result i32) | ||
(array.get_u $arr | ||
(array.new_data $arr $d (i32.const 1) (i32.const 1)) | ||
(i32.const 0)) | ||
) | ||
) | ||
|
||
;; Data inside the segment doesn't need to be aligned to the element size. | ||
(assert_return (invoke "array-new-data-unaligned") (i32.const 0x2211)) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.