-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wasm2c: atomic and shared mem operations using c11 #2308
Conversation
c8b4b83
to
cd20126
Compare
Sure, can we finish tail calls and then land this? |
@keithw Sure, let's kick off the the review process for now and we can coordinate before landing? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm definitely no shared-memory expert, but this looks pretty reasonable % comments.
1d21bed
to
1f35f1e
Compare
1f35f1e
to
ce30e9c
Compare
1c1e812
to
97be058
Compare
97be058
to
cd20f60
Compare
d829019
to
2c9fb8b
Compare
Sorry I didn't get to looking at this yet. I will try to take a look in the morning (PST) |
Apologies for taking so long to look at this one. Will try to get to it soon/today. |
2c9fb8b
to
d286e73
Compare
@keithw Just bumping this in your inbox. Please have a look at above questions when you have a chance. |
d286e73
to
a873289
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I like this method much more, personally
@@ -0,0 +1,176 @@ | |||
/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about just calling calling these wasm-rt-impl-mem.c
(so they share a common prefix with wasm-rt-impl.c
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm... this would make it inconsistent with exceptions which is in wasm-rt-exceptions-impl.c
. Happy to go with either, but we can maybe do this rename in a follow up PR to since we have to change multiple things
a873289
to
a9e9f12
Compare
Implement wasm2c atomic ops and shared memory ops with C11 atomics as discussed in #2268 (comment)
This is the first of several PRs to fully support the various primitives in the threads/shared_memory/atomics proposal.