Issue a nicer error message on wasm components. #2515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SoniEx2
approved these changes
Nov 25, 2024
|
this should probably have a dedicated test for it fwiw |
sbc100
reviewed
Nov 25, 2024
|
@sbc100 I've addressed the review feedback; would you mind taking a look? Thanks! |
sbc100
approved these changes
Dec 4, 2024
Decode just enough of the component binary format to recognize when the input is a component, and issue a dedicated error message for it. Before: 0000008: error: bad wasm file version: 0x1000d (expected 0x1) After: 0000008: error: wasm components are not yet supported in this tool
|
Rebased on main to pick up the CI fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decode just enough of the component binary format to recognize when the input is a component, and issue a dedicated error message for it.
Before:
0000008: error: bad wasm file version: 0x1000d (expected 0x1)
After:
0000008: error: wasm components are not yet supported in this tool