Make ReadBinaryOptions more strict across readers #2541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SoniEx2
force-pushed
the
binary-reader-changes
branch
from
6b98384 to
5033eb3
Compare
|
(sorry for the force push, forgot to rebase) |
|
somehow we have managed to break the |
SoniEx2
force-pushed
the
binary-reader-changes
branch
from
6fe22ca to
aa8c028
Compare
|
(CIFuzz failing is expected because CIFuzz is stored out-of-tree, see https://github.com/google/oss-fuzz/tree/master/projects/wabt - this should actually be changed if we're understanding the oss-fuzz documentation correctly, but either way it'll require coordination between the repos) |
|
we think we should migrate the fuzzers from oss-fuzz into wabt first, seems like a better idea. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a major breaking change and we don't expect CIFuzz to survive, but coupling the assumptions of the binary reader delegate with the accepted binary reader options makes some things a lot easier. it does mean CIFuzz won't be able to fuzz the interpreter reader with
stop_on_first_error = false;but we think that's for the best. (that should never have been a supported configuration, honestly.)closes #2537