Utility function for SSRF Assertions in test writers #1382
+42
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcuri82
requested changes
Nov 6, 2025
core/src/main/kotlin/org/evomaster/core/output/service/HttpWsTestCaseWriter.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/org/evomaster/core/output/service/TestSuiteWriter.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/org/evomaster/core/output/service/TestSuiteWriter.kt
Outdated
Show resolved
Hide resolved
arcuri82
requested changes
Nov 19, 2025
| } else { | ||
| lines.addSingleCommentLine("Verifying that there are no requests made to HttpCallbackVerifier before test execution.") | ||
| lines.add("assertFalse(${verifier.getVerifierName()}") | ||
| lines.addStatement("assertFalse(verifierHasReceivedRequests(${verifier.getVerifierName()}, \"${action.getName()}\"))") |
Collaborator
There was a problem hiding this comment.
if this verifierHasReceivedRequests label is used more than once in the code, should be put in a val
| initTestMethod(solution, lines, testSuiteFileName) | ||
| lines.addEmpty(2) | ||
|
|
||
| if (config.ssrf && solution.hasSsrfFaults() && format.isJava()) { |
| } | ||
| format.isJava() -> { | ||
| lines.startCommentBlock() | ||
| lines.addBlockCommentLine("Method to verify whether the HttpCallbackVerifier has received any requests.") |
Collaborator
There was a problem hiding this comment.
why the comment for Java is different for the comment for Kotlin ???
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.