Index.html in the pathname should be optional #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When fixing paths in the url for Dart-flute-wasm I neglected to handle the case where index.html is not in the URL. It should now be robust against any rename of index.html too.
✅ Deploy Preview for webkit-jetstream-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This seems to have fixed the netify preview issue reported in #54. I tested by loading https://deploy-preview-57--webkit-jetstream-preview.netlify.app/ and running it. @mstange do you want to confirm it works for you too? |
mstange
reviewed
Mar 12, 2025
| @@ -269,7 +269,7 @@ class Benchmark { | |||
| if (isInBrowser) { | |||
| // In browsers, relative imports don't work since we are not in a module. | |||
| // (`import.meta.url` is not defined.) | |||
| let pathname = location.pathname.match(/(.*)index\.html/)[1]; | |||
| const pathname = location.pathname.match(/^(.*\/)(?:[^.]+(?:\.(?:[^\/]+))+)?$/)[1]; | |||
There was a problem hiding this comment.
It might be easier to read if you use replace, for example .replace(/\/index\.html$/, '/')
There was a problem hiding this comment.
Yeah, although I'd rather do that in a follow up since I'd like to unblock this.
I can confirm that https://deploy-preview-57--webkit-jetstream-preview.netlify.app/ completes successfully, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When fixing paths in the url for Dart-flute-wasm I neglected to handle the case where index.html is not in the URL. It should now be robust against any rename of index.html too.