Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw errors in cli.js #59

Merged
merged 1 commit into from
Apr 7, 2025

Conversation

camillobruni
Copy link
Contributor

Currently the shells don't fail with an error exit code if the benchmark suite fails.

  • Both the d8 and spidermonkey shells fail with a non-zero exit status on unhandled promise rejections.
  • JSC currently only prints an error message but exits successfully

Copy link

netlify bot commented Mar 26, 2025

Deploy Preview for webkit-jetstream-preview ready!

Name Link
🔨 Latest commit abbec70
🔍 Latest deploy log https://app.netlify.com/sites/webkit-jetstream-preview/deploys/67e3dfa97ee2d10008d80069
😎 Deploy Preview https://deploy-preview-59--webkit-jetstream-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@kmiller68 kmiller68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kmiller68 kmiller68 merged commit ed6dfc1 into WebKit:main Apr 7, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants