fix: kli delegate confirm no longer hangs; and other delegated ixn fixes #1100

kentbull · 2025-11-20T20:51:39Z

This PR fixes the kli delegate confirm hanging by loosening the delegation approval check to include group multisig events, specifically dip and drt events.

Also, group ixns (interaction events) now skip unneeded approval check and OOBI resolution of a delegate no longer re-escrows already approved dip events.

Prior to this PR when performing OOBI resolution then any approved dip events were being re-added to the delegables escrow for another approval, which is incorrect because the dip was already approved. Adding a check during Kever.processEvent to look up the sequence number and digest of the seal fixes this.

And group interaction events do not need delegation approval and thus should not be sent to the delegables escrow. This PR puts a type check for dip and drt around the logic that adds items to the delegables delegation approval escrow.

There was also a third bug in the addition of dip and drt events to the delegables escrow. Only single sig events were being added to the escrow because the self.locallyDelegated() check was too restrictive and did not work for group multisig events. Adding the Kever.locallyDelegated implementation check of self.prefixes loosened the check enough to work for group multisig events.

All existing tests pass, yet this PR is needed because the existing tests around multisig ixn and dip event escrowing do not cover multisig delegation. I will add those tests to this PR so we can avoid breakages here in the future.

kentbull · 2025-11-20T22:08:04Z

This PR backports the Kever.locallyDelegated() implementation from main to this branch.

Further, the fix that if self.locallyDelegated(delpre) and not self.locallyOwned(): in valSigsWigsDel should ONLY apply to dip and drt events, not to ixn events is also needed on main and v1.3.2.

kentbull · 2025-11-20T22:34:43Z

Fixes #1087

kentbull · 2025-11-20T22:44:52Z

Fixes #503

src/keri/core/eventing.py

…re-escrows approved dip Prior to this commit when performing OOBI resolution then any approved dip events were being re-added to the delegables escrow for another approval, which is incorrect because the dip was already approved. Adding a check during Kever.processEvent to look up the sequence number and digest of the seal fixes this. And group interaction events do not need delegation approval and thus should not be sent to the delegables escrow. This PR puts a type check for dip and drt around the logic that adds items to the delegables delegation approval escrow. There was also a third bug in the addition of dip and drt events to the delegables escrow. Only single sig events were being added to the escrow because the self.locallyDelegated() check was too restrictive and did not work for group multisig events. Adding the or self.locallyMembered(delpre) check loosened the check enough to work for group multisig events Signed-off-by: Kent Bull <[email protected]>

The ked of the EXN was incorrectly being used. It should have been the ked of the original inception event (oicp). This change fixes that.

Sam recommended using the positive rather than the negative case for this if block to avoid trigerring it for non delegated events like icp and rot.

kentbull · 2026-01-09T20:41:36Z

src/keri/app/cli/commands/delegate/confirm.py

                            yield self.tock

-                        print(f"Delegate {eserder.pre} {typ} event committed.")
+                        print(f"Delegate {typ} event {eserder.pre} committed.")


Print statements in this file were reordered for readability.

kentbull · 2026-01-09T20:42:22Z

src/keri/app/cli/commands/delegate/confirm.py

+                        print(f"Delegate {typ} event {eserder.pre} committed.")

-                        self.hby.db.delegables.rem(keys=(pre, sn))
+                        self.hby.db.delegables.rem(keys=(pre, sn), val=edig)


The .rem() logic was changed here to mirror what is found in the escrow logic in core/eventing.py

kentbull · 2026-01-09T20:47:59Z

src/keri/app/cli/commands/multisig/join.py

        inits["toad"] = oicp.ked["bt"]
        inits["wits"] = oicp.ked["b"]
-        inits["delpre"] = oicp.ked["di"] if "di" in ked else None
+        inits["delpre"] = oicp.ked["di"] if "di" in oicp.ked else None


This was a bug that prevented multisig join operations from working for delegated inception and rotation, and probably for interaction as well.`

kentbull · 2026-01-09T20:52:46Z

src/keri/core/eventing.py


-        if self.locallyDelegated(delpre) and not self.locallyOwned():  # local delegator
-            # must be local if locallyDelegated or caught above as misfit
+        if serder.ilk in (Ilks.dip, Ilks.drt) and self.locallyDelegated(delpre) and not self.locallyOwned():  # local delegator of delegated event


This is the big fix to kli delegate confirm that solves #1087. The reason this solves #1087 is because interaction events would incorrectly pass through this block to be escrowed before the type guard if serder.ilk in (Ilks.dip, Ilks.drt) was added.

Only delegated inception and delegated rotation should be going to the delegables escrow.

src/keri/core/eventing.py

kentbull · 2026-01-09T21:23:16Z

src/keri/app/habbing.py

    with openHby(name=name, base=base, salt=salt, temp=temp, cf=cf) as hby:
        if (hab := hby.habByName(name)) is None:
-            hab = hby.makeHab(name=name, icount=1, isith='1', ncount=1, nsith='1', **kwa)
+            hab = hby.makeHab(name=name, icount=1, isith='1', ncount=1, nsith='1', cf=cf, **kwa)


small config bugfix to make so temp=True works correctly in tests.

kentbull · 2026-01-09T21:23:58Z

src/keri/core/eventing.py

        """
        pre = pre if pre is not None else ""
-        return self.locallyOwned(pre=pre)
+        return pre in self.prefixes


This is part of the big delegation fix. self.locallyOwned(...) was too strict of a check and excluded multisig events.

pre in self.prefixes works because self.prefixes includes multisig identifiers.

… Doers - eventing.py: Check for existing delegation seal in KEL before escrowing DIP/DRT events to delegables. This prevents re-escrowing events where delegation was already approved (e.g., via OOBI resolution or query). - app_helpers.py: Refactor MultisigDelegationApprover with leader/follower logic, helper functions, and explicit escrow release via processEvent(). Refactor MultisigInceptFollower with helper functions for clarity. - test_grouping.py: Update test_multisig_delegate with proper leader/follower approver configuration and full assertions including escrow cleanup.

kentbull · 2026-01-18T05:03:39Z

Closed in favor of #1111 and #1114

kentbull force-pushed the delegation-escrow-fixes branch from 2d1608c to c0efa85 Compare November 20, 2025 22:06

This was referenced Nov 20, 2025

kli delegate confirm hangs on KERIpy 1.2.x+ #1087

Open

Fix order of witness receipts relative to delegation approval. #503

Open

kentbull changed the title ~~fix: group ixns skip unneeded approval check; OOBI resolve no longer …~~ fix: kli delegate confirm no longer hangs; and other delegated ixn fixes Nov 20, 2025

kentbull commented Nov 25, 2025

View reviewed changes

src/keri/core/eventing.py Outdated Show resolved Hide resolved

kentbull commented Nov 25, 2025

View reviewed changes

src/keri/core/eventing.py Outdated Show resolved Hide resolved

kentbull force-pushed the delegation-escrow-fixes branch from c0efa85 to 7760105 Compare November 25, 2025 16:42

kentbull force-pushed the delegation-escrow-fixes branch from 7760105 to 2c824fe Compare November 25, 2025 18:53

kentbull added 6 commits December 11, 2025 16:08

wip multisig test fixtures

069df1b

fix: multisig join using wrong ked for delpre

ccc8f4f

The ked of the EXN was incorrectly being used. It should have been the ked of the original inception event (oicp). This change fixes that.

fix: use recommended syntax for if block

3a66908

Sam recommended using the positive rather than the negative case for this if block to avoid trigerring it for non delegated events like icp and rot.

wip: multisig delegation test with doers

0ab751f

Update docs on WitnessReceiptor.receiptDo

90cae71

test: complete delegated multisig Doer based test

1c1c71e

kentbull force-pushed the delegation-escrow-fixes branch from 94f89e8 to 1c1c71e Compare January 9, 2026 03:28

kentbull marked this pull request as ready for review January 9, 2026 03:30

kentbull commented Jan 9, 2026

View reviewed changes

src/keri/core/eventing.py Outdated Show resolved Hide resolved

kentbull force-pushed the delegation-escrow-fixes branch 2 times, most recently from 292d76d to adaf464 Compare January 9, 2026 21:11

kentbull commented Jan 9, 2026

View reviewed changes

kentbull force-pushed the delegation-escrow-fixes branch from adaf464 to 780d8f5 Compare January 12, 2026 18:39

add delegation seal lookup tests

4b3806c

m00sey requested review from m00sey and pfeairheller January 13, 2026 16:50

kentbull marked this pull request as draft January 15, 2026 15:34

kentbull closed this Jan 18, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: kli delegate confirm no longer hangs; and other delegated ixn fixes #1100

fix: kli delegate confirm no longer hangs; and other delegated ixn fixes #1100

Uh oh!

kentbull commented Nov 20, 2025 •

edited

Loading

Uh oh!

kentbull commented Nov 20, 2025

Uh oh!

kentbull commented Nov 20, 2025

Uh oh!

kentbull commented Nov 20, 2025

Uh oh!

Uh oh!

Uh oh!

kentbull Jan 9, 2026

Uh oh!

kentbull Jan 9, 2026

Uh oh!

kentbull Jan 9, 2026

Uh oh!

kentbull Jan 9, 2026

Uh oh!

Uh oh!

kentbull Jan 9, 2026

Uh oh!

kentbull Jan 9, 2026 •

edited

Loading

Uh oh!

kentbull commented Jan 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

fix: kli delegate confirm no longer hangs; and other delegated ixn fixes #1100

fix: kli delegate confirm no longer hangs; and other delegated ixn fixes #1100

Uh oh!

Conversation

kentbull commented Nov 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kentbull commented Nov 20, 2025

Uh oh!

kentbull commented Nov 20, 2025

Uh oh!

kentbull commented Nov 20, 2025

Uh oh!

Uh oh!

Uh oh!

kentbull Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

kentbull Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

kentbull Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

kentbull Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kentbull Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

kentbull Jan 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kentbull commented Jan 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

kentbull commented Nov 20, 2025 •

edited

Loading

kentbull Jan 9, 2026 •

edited

Loading