refactors witness and mailbox functionality into separate packages#919
Closed
refactors witness and mailbox functionality into separate packages#919
Conversation
Signed-off-by: Kevin Griffin <griffin.kev@gmail.com>
Signed-off-by: Kevin Griffin <griffin.kev@gmail.com>
…nchronous receipts Signed-off-by: Kevin Griffin <griffin.kev@gmail.com>
Member
|
This PR has aged out. Please reopen when ready. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There didn't seem a "piecemeal" way to do this.
The broad strokes are:
From indirecting.py the following classes were moved to a top level witness package:
WitnessStart->witness.StartHttpEndReceiptEndandFrom indirecting.py the following classes were moved to a top level mailbox package:
MailboxDirector->mailbox.DirectorPollerMailboxIterable->mailbox.IterableQryRpyMailboxIterable->mailbox.QueryReplyIterableTests were also moved to new top level packages.
Leaving indirecting.py with just
IndirectorDeprecation warning were added to the start commands.
https://github.com/keri-foundation/witness has new wrappers for the new packages.
https://github.com/keri-foundation/mailbox will have wrappers for the new packages.
Marked as draft until it can be discussed with maintainers.