Skip to content

[GStreamer][Quirks] don't set 'caps' for playbin2 #1535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

emutavchi
Copy link
Collaborator

@emutavchi emutavchi commented Jul 14, 2025

Specifying "caps" explicitly breaks auto plugging of "westeros sink" in playbin2, requiring it to be specified explicitly as well.

The change narrows down "caps" setup to uridecodebin3.
17dd664

Build-Tests Layout-Tests
✅ 🛠 wpe-246-amd64-build ✅ 🧪 wpe-246-amd64-layout
✅ 🛠 wpe-246-arm32-build ✅ 🧪 wpe-246-arm32-layout

@emutavchi emutavchi requested a review from philn as a code owner July 14, 2025 17:51
philn added a commit to philn/WebKit that referenced this pull request Jul 15, 2025
…teros quirk

https://bugs.webkit.org/show_bug.cgi?id=295969

Reviewed by NOBODY (OOPS!).

See also WebPlatformForEmbedded/WPEWebKit#1535
Based on patch from Eugene Mutavchi <[email protected]>.

* Source/WebCore/platform/gstreamer/GStreamerQuirkWesteros.cpp:
(WebCore::GStreamerQuirkWesteros::configureElement):
@philn
Copy link

philn commented Jul 15, 2025

Thanks Eugene, we're handling this in WebKit/WebKit#48041.

@philn philn closed this Jul 15, 2025
@eocanha eocanha added the upstream Related to an upstream bug (or should be at some point) label Jul 15, 2025
@philn philn reopened this Jul 15, 2025
philn added a commit to philn/WebKit that referenced this pull request Jul 16, 2025
…teros quirk

https://bugs.webkit.org/show_bug.cgi?id=295969

Reviewed by NOBODY (OOPS!).

See also WebPlatformForEmbedded/WPEWebKit#1535
Based on patch from Eugene Mutavchi <[email protected]>.

* Source/WebCore/platform/gstreamer/GStreamerQuirkWesteros.cpp:
(WebCore::GStreamerQuirkWesteros::configureElement):
webkit-commit-queue pushed a commit to philn/WebKit that referenced this pull request Jul 16, 2025
…teros quirk

https://bugs.webkit.org/show_bug.cgi?id=295969

Reviewed by Xabier Rodriguez-Calvar.

See also WebPlatformForEmbedded/WPEWebKit#1535
Based on patch from Eugene Mutavchi <[email protected]>.

* Source/WebCore/platform/gstreamer/GStreamerQuirkWesteros.cpp:
(WebCore::GStreamerQuirkWesteros::configureElement):

Canonical link: https://commits.webkit.org/297482@main
philn added a commit that referenced this pull request Jul 17, 2025
…teros quirk

https://bugs.webkit.org/show_bug.cgi?id=295969

Reviewed by Xabier Rodriguez-Calvar.

See also #1535
Based on patch from Eugene Mutavchi <[email protected]>.

* Source/WebCore/platform/gstreamer/GStreamerQuirkWesteros.cpp:
(WebCore::GStreamerQuirkWesteros::configureElement):

Canonical link: https://commits.webkit.org/297482@main
philn added a commit that referenced this pull request Jul 17, 2025
…teros quirk

https://bugs.webkit.org/show_bug.cgi?id=295969

Reviewed by Xabier Rodriguez-Calvar.

See also #1535
Based on patch from Eugene Mutavchi <[email protected]>.

* Source/WebCore/platform/gstreamer/GStreamerQuirkWesteros.cpp:
(WebCore::GStreamerQuirkWesteros::configureElement):

Canonical link: https://commits.webkit.org/297482@main
@philn
Copy link

philn commented Jul 17, 2025

Backport landed!

@philn philn closed this Jul 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream Related to an upstream bug (or should be at some point) wpe-2.46
Development

Successfully merging this pull request may close these issues.

4 participants