⚡ Bolt: Reduce lock contention in ParakeetManager

[Whamp]

User description

⚡ Bolt: Reduce lock contention in ParakeetManager

💡 What:
Refactored ParakeetManager._unload_model to release the thread lock before invoking gc.collect().

🎯 Why:
gc.collect() is a blocking operation that can take a significant amount of time. Calling it while holding the lock prevents other threads (specifically the main thread attempting ensure_loaded or transcribe) from acquiring the lock, leading to unnecessary latency spikes if a request coincides with the unload check.

📊 Impact:
Reduces the critical section duration during model unloading. While gc.collect() still impacts the process (GIL), releasing the specific ParakeetManager lock allows other threads to proceed as far as the GIL allows, rather than being blocked on an application-level mutex.

🔬 Measurement:
Verified via tests/test_parakeet_manager.py that the model is still correctly unloaded (set to None). No functional regressions found.

---

PR created automatically by Jules for task 11316606292119827467 started by @Whamp

---

PR Type

Enhancement

---

Description

• Refactored _unload_model to release lock before gc.collect()

• Reduces critical section duration during model unloading

• Prevents garbage collection from blocking concurrent requests

• Documented optimization in .jules/bolt.md

---

Diagram Walkthrough

flowchart LR
  A["_unload_model called"] --> B["Acquire lock"]
  B --> C["Set model to None"]
  C --> D["Release lock"]
  D --> E["Call gc.collect"]
  E --> F["Other threads can proceed"]

Loading

File Walkthrough

	Relevant files
Enhancement	parakeet_manager.py Move gc.collect outside lock block                                              src/chirp/parakeet_manager.py Moved gc.collect() outside the with self._lock: block Introduced should_gc flag to track when garbage collection is needed Lock is now released before the blocking garbage collection operation Allows concurrent threads to acquire the lock while GC runs +5/-1
Documentation	bolt.md Document ParakeetManager lock optimization                              .jules/bolt.md Added new optimization entry dated 2026-02-03 Documented the ParakeetManager lock contention issue Explained the solution of releasing lock before garbage collection +4/-0

---

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[qodo-code-review]

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢	No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
⚪	🎫 No ticket provided Create ticket/issue
Codebase Duplication Compliance
⚪	Codebase context is not defined Follow the guide to enable codebase context checks.
Custom Compliance
🟢	Generic: Comprehensive Audit Trails Objective: To create a detailed and reliable record of critical system actions for security analysis and compliance. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Meaningful Naming and Self-Documenting Code Objective: Ensure all identifiers clearly express their purpose and intent, making code self-documenting Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Secure Error Handling Objective: To prevent the leakage of sensitive system information through error messages while providing sufficient detail for internal debugging. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Secure Logging Practices Objective: To ensure logs are useful for debugging and auditing without exposing sensitive information like PII, PHI, or cardholder data. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Security-First Input Validation and Data Handling Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent vulnerabilities Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
⚪	Generic: Robust Error Handling and Edge Case Management Objective: Ensure comprehensive error handling that provides meaningful context and graceful degradation Status: Unhandled gc failure: The new gc.collect() call is executed without a protective try/except, so an unexpected exception could terminate the unload path/monitor loop without contextual logging. Referred Code should_gc = False with self._lock: if self._model is not None and (time.time() - self._last_access > self._timeout): self._logger.info("Unloading Parakeet model to free memory.") self._model = None should_gc = True if should_gc: gc.collect() Learn more about managing compliance generic rules or creating your own custom rules

Compliance status legend

🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

[qodo-code-review]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
General	Simplify logic by removing flag Refactor the _unload_model method to use an early return instead of the should_gc flag, simplifying the control flow. src/chirp/parakeet_manager.py [67-76] def _unload_model(self) -> None: - should_gc = False with self._lock: - if self._model is not None and (time.time() - self._last_access > self._timeout): - self._logger.info("Unloading Parakeet model to free memory.") - self._model = None - should_gc = True + if self._model is None or (time.time() - self._last_access <= self._timeout): + return # Nothing to do - if should_gc: - gc.collect() + self._logger.info("Unloading Parakeet model to free memory.") + self._model = None + # Lock is released, now we can garbage collect + gc.collect() + Apply / Chat Suggestion importance[1-10]: 6 __ Why: The suggestion correctly identifies an opportunity to refactor the code for better readability and simplicity by using a guard clause, which is a good practice.	Low
	Log garbage collection duration Add timing and logging around the gc.collect() call to monitor its duration and performance impact. src/chirp/parakeet_manager.py [75-76] if should_gc: + start = time.time() gc.collect() + self._logger.info(f"Garbage collection took {time.time() - start:.3f}s") Apply / Chat Suggestion importance[1-10]: 5 __ Why: The suggestion proposes adding logging for the duration of gc.collect(), which is useful for monitoring performance, aligning with the PR's goal of reducing blocking time.	Low
More